From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH] lib/igt_core: document the caveats of magic
 code blocks
Date: Fri, 14 Mar 2014 14:49:16 +0000
Message-ID: <532316EC.3070400@linux.intel.com>
References: <1394781488-20586-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id E1155FB225
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 14 Mar 2014 07:49:27 -0700 (PDT)
In-Reply-To: <1394781488-20586-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org


On 03/14/2014 07:18 AM, Daniel Vetter wrote:
[snip]
> + * # Magic Control Blocks
> + *
> + * i-g-t makes heavy use of C macros which serve as magic control blocks. They
> + * work fairly well and transparently but since C doesn't have full-blown
> + * closures there are caveats:
> + *
> + * - Asynchronous blocks which are used to spawn children internally use fork().
> + *   Which means that impossible control flow like jumping out of the control
> + *   block is possible, but it will horribly badly the i-g-t library code. And

I suggest to add a verb and reorder the "horribly badly" part of the 
sentence a bit. Or perhaps you tried to illustrate the program flow 
after jumping out of the control block? :)

> + * - Code blocks with magic control flow are implemented with setjmp() and
> + *   longjmp(). This applies to #igt_fixture and #igt_subtest blocks and all the
> + *   three variants to finish test: igt_success(), igt_skip() and igt_fail().
> + *   Mostly this is of no concern, except when such a control block changes
> + *   stack variables defined in the same function as the control block resides.
> + *   Any store/load behaviour after a longjmp() is ill-defined for these
> + *   variables. Avoid such code.
> + *
> + *   Quoting the man page for longjmp():
> + *
> + *   "The values of automatic variables are unspecified after a call to
> + *   longjmp() if they meet all the following criteria:"
> + *    - "they are local to the function that made the corresponding setjmp() call;
> + *    - "their values are changed between the calls to setjmp() and longjmp(); and
> + *    - "they are not declared as volatile."
>    */

So all variables which are getting initialised in igt_fixture should be 
moved out to file scope? Gcc does warn about potential clobbering 
although I haven't exactly gotten my head round understanding if and 
when it can really happen with igt_fixture.

Tvrtko