All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH v2] hw/timer/grlib_gptimer: Avoid integer overflows
Date: Fri, 14 Mar 2014 20:13:54 +0400	[thread overview]
Message-ID: <53232AC2.7040202@msgid.tls.msk.ru> (raw)
In-Reply-To: <1392549158-6009-1-git-send-email-sebastian.huber@embedded-brains.de>

16.02.2014 15:12, Sebastian Huber wrote:
> The GPTIMER uses 32-bit registers.  Use a 64-bit operation to get the
> ptimer count, otherwise we end up with a count of 0 for GPTIMER counter
> values of 0xffffffff.
> 
> Use the GPTIMER counter value for tracing to avoid an overflow of the
> 32-bit value passed to trace_grlib_gptimer_enable().

Thanks, applied to the trivial patches queue.

Somehow this was quite a bit difficult for me to understand what's going
on.  Once I did, things are really trivial indeed.

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] hw/timer/grlib_gptimer: Avoid integer overflows
Date: Fri, 14 Mar 2014 20:13:54 +0400	[thread overview]
Message-ID: <53232AC2.7040202@msgid.tls.msk.ru> (raw)
In-Reply-To: <1392549158-6009-1-git-send-email-sebastian.huber@embedded-brains.de>

16.02.2014 15:12, Sebastian Huber wrote:
> The GPTIMER uses 32-bit registers.  Use a 64-bit operation to get the
> ptimer count, otherwise we end up with a count of 0 for GPTIMER counter
> values of 0xffffffff.
> 
> Use the GPTIMER counter value for tracing to avoid an overflow of the
> 32-bit value passed to trace_grlib_gptimer_enable().

Thanks, applied to the trivial patches queue.

Somehow this was quite a bit difficult for me to understand what's going
on.  Once I did, things are really trivial indeed.

/mjt

  parent reply	other threads:[~2014-03-14 16:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-16 11:12 [Qemu-trivial] [PATCH v2] hw/timer/grlib_gptimer: Avoid integer overflows Sebastian Huber
2014-02-16 11:12 ` [Qemu-devel] " Sebastian Huber
2014-02-26  7:53 ` [Qemu-trivial] " Sebastian Huber
2014-02-26  7:53   ` Sebastian Huber
2014-03-02 13:17   ` [Qemu-trivial] " Michael Tokarev
2014-03-02 13:17     ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-02 15:56     ` [Qemu-trivial] [Qemu-devel] " Sebastian Huber
2014-03-02 15:56       ` [Qemu-devel] [Qemu-trivial] " Sebastian Huber
2014-03-12  9:48       ` [Qemu-trivial] [Qemu-devel] " Sebastian Huber
2014-03-12  9:48         ` [Qemu-devel] [Qemu-trivial] " Sebastian Huber
2014-03-14 16:13 ` Michael Tokarev [this message]
2014-03-14 16:13   ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53232AC2.7040202@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sebastian.huber@embedded-brains.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.