All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Gladkov <gladkov.alexey@gmail.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>, kbd@lists.altlinux.org
Subject: Re: [kbd] [PATCH] libkeymap: fix kmap on big-endian machines
Date: Sat, 15 Mar 2014 15:08:44 +0400	[thread overview]
Message-ID: <532434BC.6080903@gmail.com> (raw)
In-Reply-To: <1394839976-18297-1-git-send-email-aaro.koskinen@iki.fi>

15.03.2014 03:32, Aaro Koskinen wrote:
> Currently "loadkeys" does not work properly (no keys are ever changed)
> on big-endian machines (e.g. SPARC and other classic hardware)
> due to incorrect typing. The patch fixes this.
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>

Thanks!

> ---
>  src/libkeymap/kmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libkeymap/kmap.c b/src/libkeymap/kmap.c
> index e529136..85a3bb3 100644
> --- a/src/libkeymap/kmap.c
> +++ b/src/libkeymap/kmap.c
> @@ -37,7 +37,7 @@ int
>  lk_key_exists(struct lk_ctx *ctx, unsigned int k_table, unsigned int k_index)
>  {
>  	struct lk_array *map;
> -	u_short *key;
> +	unsigned int *key;
>  
>  	map = lk_array_get_ptr(ctx->keymap, k_table);
>  	if (!map) {
> 


-- 
Rgrds, legion



      reply	other threads:[~2014-03-15 11:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 23:32 [kbd] [PATCH] libkeymap: fix kmap on big-endian machines Aaro Koskinen
2014-03-15 11:08 ` Alexey Gladkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532434BC.6080903@gmail.com \
    --to=gladkov.alexey@gmail.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=kbd@lists.altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.