From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Subject: Re: [PATCH, resend] blkfront: ioctls/geometry, 2.6
Date: Fri, 2 Jun 2006 11:19:25 +0100
Message-ID: <5324398cd809a2cde429589727c53ee5@cl.cam.ac.uk>
References: <4480296D.76E4.0078.0@novell.com>
Mime-Version: 1.0 (Apple Message framework v624)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4480296D.76E4.0078.0@novell.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <jbeulich@novell.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org


On 2 Jun 2006, at 11:05, Jan Beulich wrote:

> Add backing support for HDIO_GETGEO ioctl to blkfront.
>
> Inspired by an earlier patch from Charles Coffing.

Does this have any effect? It looks to me as though HDIO_GETGEO is 
handled by block/ioctl.c:blkdev_ioctl(). I also note that *no* other 
blkdev drivers define their own HDIO_GETGEO handler. Shouldn't we just 
remove that case from our ioctl switch statement and define a 'getgeo' 
function hook?

Given that this patch can't have any effect, what drove you guys to 
implement it? :-)

  -- Keir