From: Jonathan Cameron <jic23@kernel.org>
To: Josh Wu <josh.wu@atmel.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>
Subject: Re: [PATCH] iio: adc: at91_adc: correct default shtim value
Date: Sat, 15 Mar 2014 16:34:02 +0000 [thread overview]
Message-ID: <532480FA.4010604@kernel.org> (raw)
In-Reply-To: <531704DA.5000200@atmel.com>
On 05/03/14 11:04, Josh Wu wrote:
> Hi, Alexandre
>
> On 3/4/2014 2:07 AM, Alexandre Belloni wrote:
>> When sample_hold_time is zero (this is the case when DT is not used or if
>> atmel,adc-sample-hold-time is omitted), then the calculated shtim is large.
>>
>> Make that 0, which is the default for that register and the ADC will then use a
>> sane value of 2/ADCCLK or 1/ADCCLK depending on the version.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
> Thanks for the fix and
>
> Acked-by: Josh Wu<josh.wu@atmel.com>
>
Applied to the fixes-togreg branch of iio.git.
Note that is likely that this will go upstream after the merge window now.
next prev parent reply other threads:[~2014-03-15 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 18:07 [PATCH] iio: adc: at91_adc: correct default shtim value Alexandre Belloni
2014-03-05 11:04 ` Josh Wu
2014-03-15 16:34 ` Jonathan Cameron [this message]
2014-03-15 21:21 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532480FA.4010604@kernel.org \
--to=jic23@kernel.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=josh.wu@atmel.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.