All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mtools: remove ignored configure options
Date: Mon, 17 Mar 2014 07:32:32 +0100	[thread overview]
Message-ID: <53269700.40405@mind.be> (raw)
In-Reply-To: <1394999237-30259-1-git-send-email-fhunleth@troodon-software.com>

On 03/16/14 20:47, Frank Hunleth wrote:
> The --enable-xdf, --enable-vold, and --enable-new-vold options were
> actually not being passed to ./configure since they were specified on
> the wrong variable (MTOOLS_CONF_OPT vs. HOST_MTOOLS_CONF_OPT) and mtools
> is a host-only package. Fixing the variable name so that the options are
> actually used ends up causing the build to fail due to linker errors.
> Since vold identifiers and OS/2 XDF support are unlikely to be used any
> more, remove them completely.
> 
> Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout

> ---
>  package/mtools/mtools.mk | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/package/mtools/mtools.mk b/package/mtools/mtools.mk
> index 6751059..11517df 100644
> --- a/package/mtools/mtools.mk
> +++ b/package/mtools/mtools.mk
> @@ -10,8 +10,4 @@ MTOOLS_SITE          = $(BR2_GNU_MIRROR)/mtools/
>  MTOOLS_LICENSE       = GPLv3+
>  MTOOLS_LICENSE_FILES = COPYING
>  
> -MTOOLS_CONF_OPT = --enable-xdf        \
> -                  --enable-vold       \
> -                  --enable-new-vold
> -
>  $(eval $(host-autotools-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2014-03-17  6:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-16 19:47 [Buildroot] [PATCH] mtools: remove ignored configure options Frank Hunleth
2014-03-17  6:32 ` Arnout Vandecappelle [this message]
2014-03-17 22:12 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53269700.40405@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.