From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Subject: Re: [RESEND v2 PATCH 1/2] aio, memory-hotplug: Fix confliction when migrating and accessing ring pages. Date: Mon, 17 Mar 2014 14:50:34 +0800 Message-ID: <53269B3A.4040900@cn.fujitsu.com> References: <1394439334-28523-1-git-send-email-tangchen@cn.fujitsu.com> <1394439334-28523-2-git-send-email-tangchen@cn.fujitsu.com> <20140311184656.GD16433@kvack.org> <531FEFC6.50709@cn.fujitsu.com> <20140312221735.GF32444@kvack.org> <5322D90C.5050207@cn.fujitsu.com> <20140314151446.GE29206@kvack.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gu Zheng , viro@zeniv.linux.org.uk, jmoyer@redhat.com, kosaki.motohiro@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-kernel@vger.kernel.org, miaox@cn.fujitsu.com To: Benjamin LaHaise Return-path: In-Reply-To: <20140314151446.GE29206@kvack.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 03/14/2014 11:14 PM, Benjamin LaHaise wrote: ...... >> What about the following patch? It adds additional reference to protect the page >> avoid being freed when we reading it. >> ps.It is applied on linux-next(3-13). > > I think that's even worse than the spinlock approach since we'll end up > bouncing around the struct page's cacheline in addition to spinlock we're > going to end up taking anyways. > Hi Benjamin, I'm sorry, I don't quite understand the cacheline problem you mentioned above. Would you please explain more ? Thanks.