From: Jyri Sarha <jsarha@ti.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v2] ASoC: tlv320aic31xx: Don't call kfree for memory allocated by devm_kzalloc
Date: Mon, 17 Mar 2014 09:22:53 +0200 [thread overview]
Message-ID: <5326A2CD.7060808@ti.com> (raw)
In-Reply-To: <1394982385.19788.4.camel@phoenix>
On 03/16/2014 05:06 PM, Axel Lin wrote:
> The kfree call is not necessary, but we need to call snd_soc_unregister_codec()
> in remove().
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Oops, that is a bad one. Thanks!
Acked-by: Jyri Sarha <jsarha@ti.com>
ps. I found another not as serious bug when I did unload testing with
this patch. I'll mail a patch shortly.
next prev parent reply other threads:[~2014-03-17 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-16 15:06 [PATCH v2] ASoC: tlv320aic31xx: Don't call kfree for memory allocated by devm_kzalloc Axel Lin
2014-03-17 7:22 ` Jyri Sarha [this message]
2014-03-18 12:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5326A2CD.7060808@ti.com \
--to=jsarha@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.