From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/6] Makefile: do not add the toolchain target to the TARGETS variable
Date: Mon, 17 Mar 2014 08:42:48 +0100 [thread overview]
Message-ID: <5326A778.7070507@mind.be> (raw)
In-Reply-To: <1394540278-28740-7-git-send-email-fabio.porcedda@gmail.com>
On 03/11/14 13:17, Fabio Porcedda wrote:
> Do not add the toolchain target to the TARGETS variable because now the
> toolchain target is a dependency added automatically so it is not
> necessary to add it anymore.
I disagree with this one. When you run make, you expect buildroot to
build the toolchain even if no target package is selected. One use case I
can think of: when preparing an internal toolchain for use as an external
toolchain in later builds.
Regards,
Arnout
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 0420364..481f779 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -300,7 +300,7 @@ GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
> #
> ################################################################################
>
> -TARGETS := toolchain
> +TARGETS :=
>
> # silent mode requested?
> QUIET := $(if $(findstring s,$(MAKEFLAGS)),-q)
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2014-03-17 7:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 12:17 [Buildroot] [PATCH 0/6] Miscellauneus patches Fabio Porcedda
2014-03-11 12:17 ` [Buildroot] [PATCH 1/6] barebox: fix coding style Fabio Porcedda
2014-03-11 17:33 ` Yann E. MORIN
2014-03-12 6:45 ` Arnout Vandecappelle
2014-03-13 16:35 ` Fabio Porcedda
2014-03-17 6:20 ` Arnout Vandecappelle
2014-03-11 12:17 ` [Buildroot] [PATCH 2/6] Remove "dirs" dependencies Fabio Porcedda
2014-03-12 7:09 ` Arnout Vandecappelle
2014-03-11 12:17 ` [Buildroot] [PATCH 3/6] Makefile: fix coding style Fabio Porcedda
2014-03-12 7:55 ` Arnout Vandecappelle
2014-04-09 9:21 ` Fabio Porcedda
2014-03-11 12:17 ` [Buildroot] [PATCH 4/6] luajit: needs for 32bit archictectures a 32bit host gcc Fabio Porcedda
2014-03-11 19:16 ` François Perrad
2014-03-11 12:17 ` [Buildroot] [PATCH 5/6] infra: add to luarocks support for top-level parallel make Fabio Porcedda
2014-03-11 19:42 ` François Perrad
2014-04-01 8:39 ` Fabio Porcedda
2014-03-11 12:17 ` [Buildroot] [PATCH 6/6] Makefile: do not add the toolchain target to the TARGETS variable Fabio Porcedda
2014-03-17 7:42 ` Arnout Vandecappelle [this message]
2014-03-19 11:10 ` Fabio Porcedda
2014-03-19 11:46 ` Arnout Vandecappelle
2014-03-19 18:35 ` Yann E. MORIN
2014-03-20 10:01 ` Fabio Porcedda
2014-03-20 9:38 ` Fabio Porcedda
2014-03-20 10:13 ` Arnout Vandecappelle
2014-03-11 17:38 ` [Buildroot] [PATCH 0/6] Miscellauneus patches Fabio Porcedda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5326A778.7070507@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.