From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH 4/4] xen: arm32: don't force the compiler to allocate a dummy register
Date: Mon, 17 Mar 2014 14:33:52 +0000 [thread overview]
Message-ID: <532707D0.2000807@linaro.org> (raw)
In-Reply-To: <1395064352-2128-4-git-send-email-ian.campbell@citrix.com>
Hi Ian,
On 03/17/2014 01:52 PM, Ian Campbell wrote:
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> xen/include/asm-arm/arm32/page.h | 14 ++++++--------
> xen/include/asm-arm/arm32/processor.h | 4 ++++
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/xen/include/asm-arm/arm32/page.h b/xen/include/asm-arm/arm32/page.h
> index 27027d8..beebe8b 100644
> --- a/xen/include/asm-arm/arm32/page.h
> +++ b/xen/include/asm-arm/arm32/page.h
> @@ -37,15 +37,14 @@ static inline void write_pte(lpae_t *p, lpae_t pte)
> */
> static inline void flush_xen_text_tlb_local(void)
> {
> - register unsigned long r0 asm ("r0");
Good to see it's removed :). It was a GNU C extension and preventing Xen
to build on clang.
Acked-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
prev parent reply other threads:[~2014-03-17 14:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 13:51 [PATCH 0/4 v2] xen: arm: smp & tlb cleanups Ian Campbell
2014-03-17 13:52 ` [PATCH 1/4] xen: arm: clarify naming of the Xen TLB flushing functions Ian Campbell
2014-03-17 14:10 ` Julien Grall
2014-03-19 21:10 ` Julien Grall
2014-03-17 13:52 ` [PATCH 2/4] xen: arm: flush TLB on all CPUs when setting or clearing fixmaps Ian Campbell
2014-03-17 13:52 ` [PATCH 3/4] xen: arm: add barrier before sev in smp_spin_table_cpu_up Ian Campbell
2014-03-17 14:18 ` Julien Grall
2014-03-17 14:39 ` Ian Campbell
2014-03-17 14:43 ` Julien Grall
2014-03-17 14:50 ` Ian Campbell
2014-04-02 14:03 ` Ian Campbell
2014-03-17 13:52 ` [PATCH 4/4] xen: arm32: don't force the compiler to allocate a dummy register Ian Campbell
2014-03-17 14:33 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532707D0.2000807@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.