From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH v2] gpio: davinci: fix gpio selection for OF Date: Mon, 17 Mar 2014 17:04:24 +0200 Message-ID: <53270EF8.6020908@ti.com> References: <5316FFCE.1060603@ti.com> <1394018461-757-1-git-send-email-holler@ahsoftware.de> <5322D529.4070904@ahsoftware.de> <5326F8C5.5090406@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5326F8C5.5090406-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org To: Sekhar Nori , Linus Walleij , Alexander Holler Cc: Alexandre Courbot , "davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Grant Likely , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-gpio@vger.kernel.org On 03/17/2014 03:29 PM, Sekhar Nori wrote: > On Friday 14 March 2014 04:32 PM, Linus Walleij wrote: >> On Fri, Mar 14, 2014 at 11:08 AM, Alexander Holler wrote: >>> Am 11.03.2014 11:15, schrieb Linus Walleij: >>>> On Wed, Mar 5, 2014 at 12:21 PM, Alexander Holler wrote: >>>> >>>>> The driver missed an of_xlate function to translate gpio numbers >>>>> as found in the DT to the correct chip and number. >>>>> >>>>> While there I've set #gpio_cells to a fixed value of 2. >>>>> >>>>> I've used gpio-pxa.c as template for those changes and tested my changes >>>>> successfully on a da850 board using entries for gpio-leds in a DT. So I didn't >>>>> reinvent the wheel but just copied and tested stuff. >>>>> >>>>> Thanks to Grygorii Strashko for the hint to the existing code in gpio-pxa. >>>>> >>>>> Signed-off-by: Alexander Holler >>>>> Signed-off-by: Grygorii Strashko >>>> >>>> This v2 version applied, thanks! >>> >>> Thanks, but actually that should have been a fix for 3.14 with which the >>> OF functionality for davinci gpio gets introduced. I assum with the >>> patch in for-next, 3.14 will appear with that functionality broken and >>> it will become a candidate for -stable. >> >> I just get the impression that DT support for DaVinci in v3.14 is so risky >> and unstable that noone except those implementing it (i.e. you) is really >> using it, is that correct? >> >> In that case it is hardly a fix that we need to rush out to the entire world. > > One thing to note is that this driver is used by keystone too and all > its users are DT-only. Although I do not see any in-kernel DT GPIO users > even there. > > I can confirm the patch does not break my gpiolib based test module > (test with and without DT), but then it did not have an issue even before. The issues isn't observed on Keystone2 as it has <32 gpios as of now, also GPIO support for keystone is going to be added in 3.15 (including DT changes). Regards, -grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 From: grygorii.strashko@ti.com (Grygorii Strashko) Date: Mon, 17 Mar 2014 17:04:24 +0200 Subject: [PATCH v2] gpio: davinci: fix gpio selection for OF In-Reply-To: <5326F8C5.5090406@ti.com> References: <5316FFCE.1060603@ti.com> <1394018461-757-1-git-send-email-holler@ahsoftware.de> <5322D529.4070904@ahsoftware.de> <5326F8C5.5090406@ti.com> Message-ID: <53270EF8.6020908@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/17/2014 03:29 PM, Sekhar Nori wrote: > On Friday 14 March 2014 04:32 PM, Linus Walleij wrote: >> On Fri, Mar 14, 2014 at 11:08 AM, Alexander Holler wrote: >>> Am 11.03.2014 11:15, schrieb Linus Walleij: >>>> On Wed, Mar 5, 2014 at 12:21 PM, Alexander Holler wrote: >>>> >>>>> The driver missed an of_xlate function to translate gpio numbers >>>>> as found in the DT to the correct chip and number. >>>>> >>>>> While there I've set #gpio_cells to a fixed value of 2. >>>>> >>>>> I've used gpio-pxa.c as template for those changes and tested my changes >>>>> successfully on a da850 board using entries for gpio-leds in a DT. So I didn't >>>>> reinvent the wheel but just copied and tested stuff. >>>>> >>>>> Thanks to Grygorii Strashko for the hint to the existing code in gpio-pxa. >>>>> >>>>> Signed-off-by: Alexander Holler >>>>> Signed-off-by: Grygorii Strashko >>>> >>>> This v2 version applied, thanks! >>> >>> Thanks, but actually that should have been a fix for 3.14 with which the >>> OF functionality for davinci gpio gets introduced. I assum with the >>> patch in for-next, 3.14 will appear with that functionality broken and >>> it will become a candidate for -stable. >> >> I just get the impression that DT support for DaVinci in v3.14 is so risky >> and unstable that noone except those implementing it (i.e. you) is really >> using it, is that correct? >> >> In that case it is hardly a fix that we need to rush out to the entire world. > > One thing to note is that this driver is used by keystone too and all > its users are DT-only. Although I do not see any in-kernel DT GPIO users > even there. > > I can confirm the patch does not break my gpiolib based test module > (test with and without DT), but then it did not have an issue even before. The issues isn't observed on Keystone2 as it has <32 gpios as of now, also GPIO support for keystone is going to be added in 3.15 (including DT changes). Regards, -grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756701AbaCQOMF (ORCPT ); Mon, 17 Mar 2014 10:12:05 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:51177 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756367AbaCQOMC (ORCPT ); Mon, 17 Mar 2014 10:12:02 -0400 Message-ID: <53270EF8.6020908@ti.com> Date: Mon, 17 Mar 2014 17:04:24 +0200 From: Grygorii Strashko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Sekhar Nori , Linus Walleij , Alexander Holler CC: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "davinci-linux-open-source@linux.davincidsp.com" , "linux-arm-kernel@lists.infradead.org" , Alexandre Courbot , Grant Likely , Rob Herring , Prabhakar Lad Subject: Re: [PATCH v2] gpio: davinci: fix gpio selection for OF References: <5316FFCE.1060603@ti.com> <1394018461-757-1-git-send-email-holler@ahsoftware.de> <5322D529.4070904@ahsoftware.de> <5326F8C5.5090406@ti.com> In-Reply-To: <5326F8C5.5090406@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/17/2014 03:29 PM, Sekhar Nori wrote: > On Friday 14 March 2014 04:32 PM, Linus Walleij wrote: >> On Fri, Mar 14, 2014 at 11:08 AM, Alexander Holler wrote: >>> Am 11.03.2014 11:15, schrieb Linus Walleij: >>>> On Wed, Mar 5, 2014 at 12:21 PM, Alexander Holler wrote: >>>> >>>>> The driver missed an of_xlate function to translate gpio numbers >>>>> as found in the DT to the correct chip and number. >>>>> >>>>> While there I've set #gpio_cells to a fixed value of 2. >>>>> >>>>> I've used gpio-pxa.c as template for those changes and tested my changes >>>>> successfully on a da850 board using entries for gpio-leds in a DT. So I didn't >>>>> reinvent the wheel but just copied and tested stuff. >>>>> >>>>> Thanks to Grygorii Strashko for the hint to the existing code in gpio-pxa. >>>>> >>>>> Signed-off-by: Alexander Holler >>>>> Signed-off-by: Grygorii Strashko >>>> >>>> This v2 version applied, thanks! >>> >>> Thanks, but actually that should have been a fix for 3.14 with which the >>> OF functionality for davinci gpio gets introduced. I assum with the >>> patch in for-next, 3.14 will appear with that functionality broken and >>> it will become a candidate for -stable. >> >> I just get the impression that DT support for DaVinci in v3.14 is so risky >> and unstable that noone except those implementing it (i.e. you) is really >> using it, is that correct? >> >> In that case it is hardly a fix that we need to rush out to the entire world. > > One thing to note is that this driver is used by keystone too and all > its users are DT-only. Although I do not see any in-kernel DT GPIO users > even there. > > I can confirm the patch does not break my gpiolib based test module > (test with and without DT), but then it did not have an issue even before. The issues isn't observed on Keystone2 as it has <32 gpios as of now, also GPIO support for keystone is going to be added in 3.15 (including DT changes). Regards, -grygorii