From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH 2/2] x86/MTRR: optionally print boot time
 state
Date: Mon, 17 Mar 2014 15:29:19 +0000
Message-ID: <532714CF.60305@linaro.org>
References: <531DA89F02000078001224D1@nat28.tlf.novell.com>
	<531DAB2E020000780012250B@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WPZTe-0006nc-Pa
	for xen-devel@lists.xenproject.org; Mon, 17 Mar 2014 15:29:22 +0000
Received: by mail-wg0-f47.google.com with SMTP id x12so4671448wgg.18
	for <xen-devel@lists.xenproject.org>;
	Mon, 17 Mar 2014 08:29:21 -0700 (PDT)
In-Reply-To: <531DAB2E020000780012250B@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

Hi Jan,

On 03/10/2014 11:08 AM, Jan Beulich wrote:
> +static bool_t __initdata mtrr_show;
> +boolean_param("mtrr.show", mtrr_show);
> +
> +static const char *__init mtrr_attrib_to_str(mtrr_type x)
> +{
> +	static const char __initconst strings[MTRR_NUM_TYPES][16] =
> +	{
> +		[0 ... MTRR_NUM_TYPES - 1] = "?",
> +		[MTRR_TYPE_UNCACHABLE]     = "uncachable",
> +		[MTRR_TYPE_WRCOMB]         = "write-combining",
> +		[MTRR_TYPE_WRTHROUGH]      = "write-through",
> +		[MTRR_TYPE_WRPROT]         = "write-protect",
> +		[MTRR_TYPE_WRBACK]         = "write-back",
> +	};

This patch is breaking compilation with clang 3.0:

generic.c:95:32: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
                [MTRR_TYPE_UNCACHABLE]     = "uncachable",
                                             ^~~~~~~~~~~~
generic.c:94:32: note: previous initialization is here
                [0 ... MTRR_NUM_TYPES - 1] = "?",
                                             ^~~

Do you mind if I send a patch to replace by something like:
	[2] = "?"
        [3] = "?"

Regards,

-- 
Julien Grall