From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 10/15] xen/xsm: flask: flask_copying_string is taking a XEN_GUEST_HANDLE as first param Date: Mon, 17 Mar 2014 15:46:05 +0000 Message-ID: <532718BD.5000805@linaro.org> References: <1395065165-15915-1-git-send-email-julien.grall@linaro.org> <1395065165-15915-11-git-send-email-julien.grall@linaro.org> <532725580200007800124DA4@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WPZjv-0000Or-5C for xen-devel@lists.xenproject.org; Mon, 17 Mar 2014 15:46:11 +0000 Received: by mail-wi0-f176.google.com with SMTP id hr14so2363948wib.15 for ; Mon, 17 Mar 2014 08:46:08 -0700 (PDT) In-Reply-To: <532725580200007800124DA4@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org Hi Jan, On 03/17/2014 03:39 PM, Jan Beulich wrote: >>>> On 17.03.14 at 15:06, Julien Grall wrote: >> Rather than x86, on ARM XEN_GUEST_HANDLE and XEN_GUEST_HANDLE_PARAM are >> not compatible. This will result to a compilation failure on ARM when XSM >> will be enabled. >> >> Signed-off-by: Julien Grall >> Acked-by: Daniel De Graaf >> Acked-by: Ian Campbell >> --- >> xen/xsm/flask/flask_op.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c >> index 9dd9081..85a615b 100644 >> --- a/xen/xsm/flask/flask_op.c >> +++ b/xen/xsm/flask/flask_op.c >> @@ -76,7 +76,7 @@ static int domain_has_security(struct domain *d, u32 perms) >> perms, NULL); >> } >> >> -static int flask_copyin_string(XEN_GUEST_HANDLE_PARAM(char) u_buf, char **buf, >> +static int flask_copyin_string(XEN_GUEST_HANDLE(char) u_buf, char **buf, > > Wasn't the original intention for them to be converted when passed > to functions, rather than getting passed verbatim? I didn't find any place where the conversation is made. If we are going to this solution, can you give me pointer on how to do the conversation? Regards, -- Julien Grall