Re: [PATCH] xen: arm: setup sane EL1 state while building domain 0.

[Julien Grall <julien.grall@linaro.org>]

On 03/17/2014 03:46 PM, Ian Campbell wrote:
> On Mon, 2014-03-17 at 15:37 +0000, Julien Grall wrote:
>> void p2m_restore_state(struct vcpu *n)
> 
> I think setup_state might be more indicative of the operation.
> 
>> {
>>     register_t hcr;
>>
>>     hcr = READ_SYSREG(HCR_EL2);
>>     WRITE_SYSREG(hcr & ~HCR_VM, HCR_EL2);
>>     isb();
> 
> I know we do this on context switch now but I think it is unnecessary
> and I plan to remove it.

Thanks to confirm, I wasn't sure if it was necessary or not.

>> IHMO, it's more clear than continuing "hardcoding" setup in dom0 code.
> 
> Are there any other potential callers?

Yes ctx_to_switch, so everything related to P2M context switch is
restrict to p2m.c. That why I choose this name, there is also a sister
function which will save the p2m context (p2m_save_state).

-- 
Julien Grall