Re: [PATCH v2 0/5] nfs: consolidate rename code into one set of functions

[Anna Schumaker <schumaker.anna@gmail.com>]

Just to let you know, I tested these a bit this morning and I haven't had any problems.

Anna

On 03/17/2014 07:06 AM, Jeff Layton wrote:
> Summary of changes:
>
> v2: remove -ERESTARTSYS error handling in nfs_rename
>     hardcode isdir value in fsnotify_nameremove call for sillyrenames
>      
> As Trond pointed out recently, it makes little sense to maintain two
> separate sets of functions for handling RENAMEs.
>
> This patchset converts nfs_rename to use the asynchronous RENAME
> infrastructure that is already in place for sillyrenames. It also
> does some cleanup to remove some minor layering violations, and
> adds a patch to make the sillyrename code emit a fsnotify_nameremove
> when a sillyrename succeeds.
>
> I've lightly tested this set and it seems to do the right thing,
> but it obviously could stand some time in linux-next.
>
> Jeff Layton (5):
>   nfs: abstract out code needed to complete a sillyrename
>   nfs: make nfs_async_rename non-static
>   nfs: convert nfs_rename to use async_rename infrastructure
>   nfs: remove synchronous rename code
>   nfs: emit a fsnotify_nameremove call in sillyrename codepath
>
>  fs/nfs/dir.c            | 13 +++++++++++--
>  fs/nfs/internal.h       |  7 +++++++
>  fs/nfs/nfs3proc.c       | 36 ------------------------------------
>  fs/nfs/nfs4proc.c       | 44 --------------------------------------------
>  fs/nfs/proc.c           | 25 -------------------------
>  fs/nfs/unlink.c         | 35 ++++++++++++++++++++++++++++++-----
>  include/linux/nfs_fs.h  |  1 -
>  include/linux/nfs_xdr.h |  3 +--
>  8 files changed, 49 insertions(+), 115 deletions(-)
>