All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k <ath10k@lists.infradead.org>
Subject: Re: Proper way to do warm-reset from the driver?
Date: Mon, 17 Mar 2014 09:05:57 -0700	[thread overview]
Message-ID: <53271D65.4020603@candelatech.com> (raw)
In-Reply-To: <87r461l0wh.fsf@kamboji.qca.qualcomm.com>

On 03/17/2014 12:50 AM, Kalle Valo wrote:
> Ben Greear <greearb@candelatech.com> writes:
> 
>> On my firmware, I am often seeing 'tx not flushed' errors after bouncing
>> 32 stations a few times.
>>
>> It does not seem this error can ever be recovered because the
>> reference counting is messed up.
>>
>> I am planning to attempt a warm reset in this case, in hopes it
>> will clear things up.
>>
>> Is the preferred way to restart the nic just:
>>
>> queue_work(ar->workqueue, &ar->restart_work);
> 
> BTW, that call really should not be in ath10k_pci_hif_dump_area(). It's
> very misleading to have a function name which implies just printing
> stuff but actually also restarts firmware.

Yes, and it is not always called from that method anyway...bails
out before resetting in some error cases.

My own tree has lots of patches to that method to dump more
firmware memory areas and such, so it will not be so easy
for me to produce a clean patch to fix this...

Thanks,
Ben
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

      reply	other threads:[~2014-03-17 16:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 22:04 Proper way to do warm-reset from the driver? Ben Greear
2014-03-17  7:50 ` Kalle Valo
2014-03-17 16:05   ` Ben Greear [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53271D65.4020603@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.