From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPbT0-0000Ik-CC for qemu-devel@nongnu.org; Mon, 17 Mar 2014 13:36:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPbSv-00077H-99 for qemu-devel@nongnu.org; Mon, 17 Mar 2014 13:36:50 -0400 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:46844 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPbSu-000777-Lt for qemu-devel@nongnu.org; Mon, 17 Mar 2014 13:36:45 -0400 Message-ID: <532732A8.9080207@kamp.de> Date: Mon, 17 Mar 2014 18:36:40 +0100 From: Peter Lieven MIME-Version: 1.0 References: <20140314160616.GA16438@sergelap> <1395063841.5663.9.camel@nilsson.home.kraxel.org> <53270033.4080100@kamp.de> <20140317141012.GE7725@sergelap> <53270E30.4080400@dlhnet.de> <20140317151933.GA29848@sergelap> <532714C8.9070204@kamp.de> <20140317173519.GA26776@sergelap> In-Reply-To: <20140317173519.GA26776@sergelap> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] vnc regression with -vga vmware List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Hallyn Cc: Doug Smythies , Peter Lieven , Gerd Hoffmann , qemu-devel@nongnu.org On 17.03.2014 18:35, Serge Hallyn wrote: > Quoting Peter Lieven (pl@kamp.de): >> On 17.03.2014 16:19, Serge Hallyn wrote: >>> Quoting Peter Lieven (lieven-lists@dlhnet.de): >>>> I found 2 issues: >>>> >>>> - with vmware VGA the server surface and the client desktop size are out of sync for some time >>>> at a resolution change. the server surface gets updates for x coordinates that are out of bound >>>> for the client. >>>> - the max width of the client (2360) is not dividable by 16 (VNC_DIRTY_PIXELS_PER_BIT). >>>> >>>> I will try to fix this in ui/vnc but we should definetly look for the root cause. >>> Thanks, Peter! >>> >>> -serge >> >> The vmware vga driver seems to do some nasty things. >> I receive the msg like this (independent of ui/vnc): >> vmsvga_update_rect: update x was < 0 (-65) >> >> Can you try the following patch: > Indeed, with this patch it seems quite stable, thanks. Thanks for the feedback. I will send a patch to the list shortly. Peter > > -serge > >> diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c >> index bd2c108..6ae3348 100644 >> --- a/hw/display/vmware_vga.c >> +++ b/hw/display/vmware_vga.c >> @@ -25,6 +25,7 @@ >> #include "hw/loader.h" >> #include "trace.h" >> #include "ui/console.h" >> +#include "ui/vnc.h" >> #include "hw/pci/pci.h" >> >> #undef VERBOSE >> @@ -218,7 +219,7 @@ enum { >> >> /* These values can probably be changed arbitrarily. */ >> #define SVGA_SCRATCH_SIZE 0x8000 >> -#define SVGA_MAX_WIDTH 2360 >> +#define SVGA_MAX_WIDTH ROUND_UP(2360, VNC_DIRTY_PIXELS_PER_BIT) >> #define SVGA_MAX_HEIGHT 1770 >> >> #ifdef VERBOSE >> diff --git a/ui/vnc.c b/ui/vnc.c >> index 9c84b3e..5925774 100644 >> --- a/ui/vnc.c >> +++ b/ui/vnc.c >> @@ -888,7 +888,7 @@ static int vnc_update_client(VncState *vs, int has_dirty, bool sync) >> VncDisplay *vd = vs->vd; >> VncJob *job; >> int y; >> - int height; >> + int height, width; >> int n = 0; >> >> if (vs->output.offset && !vs->audio_cap && !vs->force_update) >> @@ -907,6 +907,7 @@ static int vnc_update_client(VncState *vs, int has_dirty, bool sync) >> job = vnc_job_new(vs); >> >> height = MIN(pixman_image_get_height(vd->server), vs->client_height); >> + width = MIN(pixman_image_get_width(vd->server), vs->client_width); >> >> y = 0; >> for (;;) { >> @@ -925,8 +926,11 @@ static int vnc_update_client(VncState *vs, int has_dirty, bool sync) >> VNC_DIRTY_BPL(vs), x); >> bitmap_clear(vs->dirty[y], x, x2 - x); >> h = find_and_clear_dirty_height(vs, y, x, x2, height); >> - n += vnc_job_add_rect(job, x * VNC_DIRTY_PIXELS_PER_BIT, y, >> - (x2 - x) * VNC_DIRTY_PIXELS_PER_BIT, h); >> + x2 = MIN(x2, width / VNC_DIRTY_PIXELS_PER_BIT); >> + if (x2 > x) { >> + n += vnc_job_add_rect(job, x * VNC_DIRTY_PIXELS_PER_BIT, y, >> + (x2 - x) * VNC_DIRTY_PIXELS_PER_BIT, h); >> + } >> } >> >> vnc_job_push(job); >> >> Peter >> >> >>