From: David Vrabel <david.vrabel@citrix.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
<xen-devel@lists.xenproject.org>,
kbuild test robot <fengguang.wu@intel.com>, <kbuild-all@01.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen: declare notifier_block on xen-ops.h
Date: Mon, 17 Mar 2014 17:56:03 +0000 [thread overview]
Message-ID: <53273733.6080506@citrix.com> (raw)
In-Reply-To: <20140317074850.GB1767@redhat.com>
On 17/03/14 07:48, Stanislaw Gruszka wrote:
> Patch fixes below warnings:
>
> In file included from arch/x86/xen/xen-ops.h:7:0,
> from arch/x86/xen/vga.c:9:
>>> include/xen/xen-ops.h:19:42: warning: 'struct notifier_block' declared inside parameter list [enabled by default]
> void xen_resume_notifier_register(struct notifier_block *nb);
> ^
>>> include/xen/xen-ops.h:19:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>>> include/xen/xen-ops.h:20:44: warning: 'struct notifier_block' declared inside parameter list [enabled by default]
> void xen_resume_notifier_unregister(struct notifier_block *nb);
Is this a fix up to your previous "xen/acpi-processor: fix enabling
interrupts on syscore_resume" patch? If so, do you mind if we squash
the two commits together? So bisectability is improved.
David
next prev parent reply other threads:[~2014-03-17 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5323aab1.r24xwrkmR/N+a3KK%fengguang.wu@intel.com>
2014-03-17 7:48 ` [PATCH] xen: declare notifier_block on xen-ops.h Stanislaw Gruszka
2014-03-17 17:56 ` David Vrabel
2014-03-17 17:56 ` David Vrabel [this message]
2014-03-18 6:52 ` [Xen-devel] " Stanislaw Gruszka
2014-03-18 6:52 ` Stanislaw Gruszka
2014-03-17 7:48 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53273733.6080506@citrix.com \
--to=david.vrabel@citrix.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.