Re: [Linux-kernel] [RFC 3/6] ARM: shmobile: add sh_pm_runtime_init() to header

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 03/17/2014 05:28 PM, Ben Hutchings wrote:

>>>> Add definition of sh_pm_runtime_init() to machine header to allow calling

>>> declaration not definition

>>>> the pm_runtime initialisation code.

>>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>>> ---
>>>>    arch/arm/mach-shmobile/include/mach/common.h | 2 ++
>>>>    1 file changed, 2 insertions(+)

>>>> diff --git a/arch/arm/mach-shmobile/include/mach/common.h b/arch/arm/mach-shmobile/include/mach/common.h
>>>> index cb8e32d..4727d4f 100644
>>>> --- a/arch/arm/mach-shmobile/include/mach/common.h
>>>> +++ b/arch/arm/mach-shmobile/include/mach/common.h
>>>> @@ -52,4 +52,6 @@ static inline void __init shmobile_init_late(void)
>>>>    	shmobile_cpuidle_init();
>>>>    }
>>>>
>>>> +extern int sh_pm_runtime_init(void);
>>>> +
>>>>    #endif /* __ARCH_MACH_COMMON_H */

>>> The declaration should include '__init'

>>      Since when? It makes no sense for declarations.

> It doesn't make any difference to the compiler, but it can be useful for
> the programmer to see it.

    I personally use 'make TAGS' on the kernel directory, and EMACS then shows 
me the function definition, not declaration when I press <Alt>-<.> (I wish it 
always worked correctly though). In general, people tend to remove '__init' 
from the declarations as I could observe so far...

> Ben.

>>> and need not include 'extern'.

WBR, Sergei