From: "H. Peter Anvin" <hpa@zytor.com>
To: chandramouli narayanan <mouli@linux.intel.com>,
Marek Vasut <marex@denx.de>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
ilya.albrekht@intel.com, maxim.locktyukhin@intel.com,
ronen.zohar@intel.com, wajdi.k.feghali@intel.com,
tim.c.chen@linux.intel.com, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 2/2] SHA1 transform: x86_64 AVX2 optimization - glue & build-v2
Date: Mon, 17 Mar 2014 11:37:23 -0700 [thread overview]
Message-ID: <532740E3.7020600@zytor.com> (raw)
In-Reply-To: <1395075232.7495.148.camel@pegasus.jf.intel.com>
On 03/17/2014 09:53 AM, chandramouli narayanan wrote:
> On second thoughts, with sha1-sse3-(CONFIG_AS_AVX2) +=
> sha1_avx2_x86_64_asm.o, I have build issues and sha1_transform_avx2
> undefined in sha1-sss3.ko.
>
> I can rid #ifdef CONFIG_AS_AVX2 in patch1. The following works though:
> ifeq ($(avx2_supported),yes)
> sha1-ssse3-y += sha1_avx2_x86_64_asm.o
> endif
Yes, the sad thing is that the CONFIG_AS_* things aren't real config
symbols, despite the name. They might be in the future when Kconfig can
run test probes (something we have needed for a very long time.)
The "yes" versus "y", though, is a total faceplant.
-hpa
prev parent reply other threads:[~2014-03-17 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 18:47 [PATCH 2/2] SHA1 transform: x86_64 AVX2 optimization - glue & build-v2 chandramouli narayanan
2014-03-14 5:40 ` Marek Vasut
2014-03-17 15:53 ` chandramouli narayanan
2014-03-17 16:06 ` Marek Vasut
2014-03-17 16:53 ` chandramouli narayanan
2014-03-17 18:11 ` Marek Vasut
2014-03-17 19:09 ` chandramouli narayanan
2014-03-17 18:37 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532740E3.7020600@zytor.com \
--to=hpa@zytor.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=ilya.albrekht@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=marex@denx.de \
--cc=maxim.locktyukhin@intel.com \
--cc=mouli@linux.intel.com \
--cc=ronen.zohar@intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=wajdi.k.feghali@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.