From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42537)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WPccu-0000I6-LE
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 14:51:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WPcco-0005xX-LW
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 14:51:08 -0400
Received: from cantor2.suse.de ([195.135.220.15]:37989 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WPcco-0005xO-FJ
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 14:51:02 -0400
Message-ID: <53274415.6050502@suse.de>
Date: Mon, 17 Mar 2014 19:51:01 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1394786300-18017-1-git-send-email-famz@redhat.com>	<53234132.8040301@weilnetz.de>
	<87y509fcrq.fsf@blackfin.pond.sub.org>
In-Reply-To: <87y509fcrq.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Makefile: Don't find and delete when
 $(DSOSUF) is empty in "make clean"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Fam Zheng <famz@redhat.com>, stefanha@redhat.com, qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>

Am 17.03.2014 09:30, schrieb Markus Armbruster:
> Stefan Weil <sw@weilnetz.de> writes:
>=20
>> Am 14.03.2014 09:38, schrieb Fam Zheng:
>>> DANGEROUS: don't try it before you read to the end.
>>>
>>> A first "make distclean" will unset $(DSOSUF), a following "make
>>> distclean" or "make clean" will find all the files and delete it.
>>>
>>> Including all the files in the .git directory!
>>
>> If you only use out-of-tree build, you are safe here. Maybe we should =
no
>> longer support in-tree builds. Personally, I nearly never use them.
>=20
> Same here.  Building in-tree is calling for trouble.  I'd support a
> patch that prevents it.

What about disabling it only when .git/ is available? There seems
nothing wrong with doing one-time builds inside an extracted tarball on
central build servers; most of the problems arise when building inside
the developer's git checkout.

If we do drop support for building in-tree (always or with Git), we
could also drop most of the .gitignore clutter. :)

Cheers,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg