From: Sasha Levin <sasha.levin@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] improve_stack: make stack dump output useful again
Date: Mon, 17 Mar 2014 15:53:19 -0400 [thread overview]
Message-ID: <532752AF.2080602@oracle.com> (raw)
In-Reply-To: <CA+55aFzzDDNLc3NzDSJ1q3ctyVJK9FXyCUxzBwQeoUHR94BLnA@mail.gmail.com>
On 03/17/2014 03:49 PM, Linus Torvalds wrote:
> On Mon, Mar 17, 2014 at 12:31 PM, Sasha Levin <sasha.levin@oracle.com> wrote:
>>
>> What about duplicate symbol names? Without the full hex address we lose
>> the ability to correctly translate from symbol name to file/line.
>
> Yeah, and we should strive to avoid that issue.
>
> The thing is, think about address randomization. We can pretty much
> assume that is going to be the standard behavior due to it being
> really cheap (just a trivial boot time cost), and helping some
> security issues.
>
> So we might have a few ambiguous cases, that's still better than the
> alternative.
Makes sense. I'll send a patch to rename a small number of "high profile" symbols
that appear often and are duplicated to the respective subsystem maintainers.
Thanks,
Sasha
prev parent reply other threads:[~2014-03-17 19:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-16 18:33 [PATCH] improve_stack: make stack dump output useful again Sasha Levin
2014-03-16 18:55 ` Linus Torvalds
2014-03-17 19:31 ` Sasha Levin
2014-03-17 19:49 ` Linus Torvalds
2014-03-17 19:53 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532752AF.2080602@oracle.com \
--to=sasha.levin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.