From: Jeremy Linton <jlinton@tributary.com>
To: Hannes Reinecke <hare@suse.de>,
James Bottomley <jbottomley@parallels.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 6/6] Invalidate VPD page data
Date: Mon, 17 Mar 2014 17:11:29 -0500 [thread overview]
Message-ID: <53277311.9000105@tributary.com> (raw)
In-Reply-To: <1394873512-102073-7-git-send-email-hare@suse.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 3/15/2014 3:51 AM, Hannes Reinecke wrote:
> Add a flag 'vpd_invalid' to the SCSI device to indicate that the VPD data
> needs to be refreshed. This is required if either a manual rescan is
> triggered or if the sense code INQUIRY DATA HAS CHANGED has been received.
> --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -393,6
> +393,7 @@ static void scsi_report_sense(struct scsi_device *sdev,
>
> if (sshdr->sense_key == UNIT_ATTENTION) { if (sshdr->asc == 0x3f &&
> sshdr->ascq == 0x03) { + sdev->vpd_invalid = 1;
I didn't study the whole code path but does the VPD data get updated on a
6/2900? I suspect it should be.
I can imagine a number of cases where the luns changed check condition gets
preempted/lost by a device reset. I guess much of that should be masked by the
port login/logout, but its probably better to be safe...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTJ3MRAAoJEL5i86xrzcy7vsAIAKyiMPZ0FBlLRxlQsGQxHaet
8FTCoj0GtgE1hmw+BfLvKzdR5VqMNt/yTSsJd/8OZrykDQ298TQlfgoSle7/dpYp
FDaMq2uXINGpe+EC/OvVGH8GJbOgdjLectwu2EqKhkMblpyBPM83XXWNOD1lbLYf
/TN/WPug9s5NOwdwSxeNhZRZKVw/9T33fxVKlXQg/sExfjIeFqHSTxIRH9bvktvw
/ewe85P8WNtTXwZUGj1O3PaPzg0B98+LgHmAJNYREBf7t/mDZpkR492Ty9fRKkxi
SauSIvdaNWuc28a88xaJGD+WRDPqSbLjecpNnWiYNfbNrNKx/WoJUpfVJS+Ltmk=
=mfSZ
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-03-17 22:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 8:51 [PATCHv9 0/6] Display EVPD pages in sysfs Hannes Reinecke
2014-03-15 8:51 ` [PATCH 1/6] scsi_sysfs: Implement 'is_visible' callback Hannes Reinecke
2014-03-15 8:51 ` [PATCH 2/6] scsi: Return VPD page length in scsi_vpd_inquiry() Hannes Reinecke
2014-03-19 16:38 ` Tomas Henzl
2014-03-15 8:51 ` [PATCH 3/6] Add EVPD page 0x83 to sysfs Hannes Reinecke
2014-03-15 8:51 ` [PATCH 4/6] Add EVPD page 0x80 " Hannes Reinecke
2014-03-15 8:51 ` [PATCH 5/6] ses: Use vpd information from scsi_device Hannes Reinecke
2014-03-15 8:51 ` [PATCH 6/6] Invalidate VPD page data Hannes Reinecke
2014-03-17 22:11 ` Jeremy Linton [this message]
2014-03-18 6:52 ` Hannes Reinecke
2014-03-18 13:23 ` James Bottomley
2014-03-18 14:45 ` Elliott, Robert (Server Storage)
2014-03-20 13:37 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53277311.9000105@tributary.com \
--to=jlinton@tributary.com \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.