From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53286)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WPfsc-0003ma-7L
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 18:19:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WPfsW-0001Wu-8a
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 18:19:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28989)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WPfsW-0001Wk-1J
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 18:19:28 -0400
Message-ID: <532774DD.9000905@redhat.com>
Date: Mon, 17 Mar 2014 23:19:09 +0100
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1395093892-29271-1-git-send-email-mreitz@redhat.com>
	<1395093892-29271-2-git-send-email-mreitz@redhat.com>
In-Reply-To: <1395093892-29271-2-git-send-email-mreitz@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/2] qcow2: Correct comment for
	realloc_refcount_block()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, =?ISO-8859-1?Q?Beno=EEt_Canet?= <benoit@irqsave.net>, Stefan Hajnoczi <stefanha@redhat.com>

On 03/17/14 23:04, Max Reitz wrote:
> Contrary to the comment describing this function's behavior, it does not
> return 0 on success, but rather the offset of the newly allocated
> cluster. This patch adjusts the comment accordingly to reflect the
> actual behavior.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  block/qcow2-refcount.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
> index 6151148..3f2ed08 100644
> --- a/block/qcow2-refcount.c
> +++ b/block/qcow2-refcount.c
> @@ -1383,7 +1383,7 @@ static int write_reftable_entry(BlockDriverState *bs, int rt_index)
>   * does _not_ decrement the reference count for the currently occupied cluster.
>   *
>   * This function prints an informative message to stderr on error (and returns
> - * -errno); on success, 0 is returned.
> + * -errno); on success, the offset of the newly allocated cluster is returned.
>   */
>  static int64_t realloc_refcount_block(BlockDriverState *bs, int reftable_index,
>                                        uint64_t offset)
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>