From: Clemens Ladisch <clemens@ladisch.de>
To: Roman Volkov <v1ron@mail.ru>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH RFC] ALSA: oxygen: Xonar DG(X): fix Stereo Upmixing regression
Date: Tue, 18 Mar 2014 09:31:25 +0100 [thread overview]
Message-ID: <5328045D.6030908@ladisch.de> (raw)
In-Reply-To: <20140318113539.5340579f@v1ron-desktop>
Roman Volkov wrote:
> Clemens Ladisch <clemens@ladisch.de> пишет:
>> The code introduced in commit 1f91ecc14dee ("ALSA: oxygen: modify
>> adjust_dg_dac_routing function") accidentally disregarded the old
>> value of the playback routing register, so it broke the "Stereo
>> Upmixing" mixer control.
>>
>> The unmuted parts of the channel routing are the same for all settings
>> of the output destination, so it suffices to revert that part of the
>> patch.
>>
>> Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
>> ---
>> sound/pci/oxygen/xonar_dg.c | 30 ++++++++++++++++++++++++------
>> 1 file changed, 24 insertions(+), 6 deletions(-)
>
> I have problems with applying this patch on my local repo. Could you
> please tell me which git repo are you using?
It's based on tiwai/sound.git, but Linus' tree should work too.
Regards,
Clemens
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2014-03-18 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 21:12 [PATCH RFC] ALSA: oxygen: Xonar DG(X): fix Stereo Upmixing regression Clemens Ladisch
2014-03-18 7:35 ` Roman Volkov
2014-03-18 8:31 ` Clemens Ladisch [this message]
2014-03-18 8:31 ` [PATCH] " Clemens Ladisch
2014-03-18 8:53 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5328045D.6030908@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=v1ron@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.