All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 1/2] Fix pvdisplay to refer to sectors, not KB
Date: Tue, 18 Mar 2014 10:36:48 +0100	[thread overview]
Message-ID: <532813B0.8080609@redhat.com> (raw)
In-Reply-To: <53280DAE.3020103@suse.de>

Dne 18.3.2014 10:11, Hannes Reinecke napsal(a):
> On 03/18/2014 09:57 AM, Zdenek Kabelac wrote:
>> Dne 18.3.2014 09:24, Hannes Reinecke napsal(a):
>>> From: Thomas Fehr <fehr@suse.de>
>>>
>>> The size is displayed in sectors, not kilobytes.
>>>
>>> Signed-off-by: Thomas Fehr <fehr@suse.de>
>>> Acked-by: Hannes Reinecke <hare@suse.de>
>>> ---
>>>    man/pvdisplay.8.in | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/man/pvdisplay.8.in b/man/pvdisplay.8.in
>>> index 03c12c4..13c26b5 100644
>>> --- a/man/pvdisplay.8.in
>>> +++ b/man/pvdisplay.8.in
>>> @@ -65,7 +65,7 @@ The values are:
>>>
>>>    * physical volume device name
>>>    * volume group name
>>> -* physical volume size in kilobytes
>>> +* physical volume size in sectors
>>>    * internal physical volume number (obsolete)
>>>    * physical volume status
>>>    * physical volume (not) allocatable
>>
>> Hi
>>
>> Against which version of lvm2 is this patch ?
>>
>> Since my upstream pvdisplay shows  size in  'human readable' format
>> i.e.:
>> (So definitely not in sector - unless used with option  '--units s')
>>
>> --- Physical volume ---
>> PV Name               /dev/loop0
>> VG Name               vg
>> PV Size               976,56 GiB / not usable 0
>> Allocatable           yes
>> PE Size               32,00 KiB
>> Total PE              31999968
>> Free PE               31999872
>> Allocated PE          96
>> PV UUID               5DOVI6-ioCm-LJvd-JbwQ-qJc3-FWO4-yQCjGY
>>
> Did I mention that these patches are ancient?
> (Originally developed in 2007 ...)
>
> I'm just doing house-keeping for our lvm2 package at the moment.
> So I'm not at all surprised this patch is obsolete.
>

Ahh - and I've missed it's for section  '-c, --colon'  and I guess it
still applies for those printed values - since the size is there in sectors  - 
though people are most probably using 'pvs'.

Zdenek




  reply	other threads:[~2014-03-18  9:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18  8:24 [PATCH 0/2] Ancient SUSE patches Hannes Reinecke
2014-03-18  8:24 ` [PATCH 1/2] Fix pvdisplay to refer to sectors, not KB Hannes Reinecke
2014-03-18  8:57   ` Zdenek Kabelac
2014-03-18  9:11     ` Hannes Reinecke
2014-03-18  9:36       ` Zdenek Kabelac [this message]
2014-03-18  8:24 ` [PATCH 2/2] Handle duplicate PVs on drbd Hannes Reinecke
2014-03-18  9:10   ` Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532813B0.8080609@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.