From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH] drm/exynos: set the active aspect ratio as per mode Date: Tue, 18 Mar 2014 14:04:18 +0100 Message-ID: <53284452.7000007@samsung.com> References: <1394688508-5429-1-git-send-email-s.shirish@samsung.com> <1394688508-5429-2-git-send-email-s.shirish@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by gabe.freedesktop.org (Postfix) with ESMTP id BA86E8D1F8 for ; Tue, 18 Mar 2014 06:04:25 -0700 (PDT) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N2M00ICJUZ4WT40@mailout2.w1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 18 Mar 2014 13:04:16 +0000 (GMT) In-reply-to: <1394688508-5429-2-git-send-email-s.shirish@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Shirish S , dri-devel@lists.freedesktop.org, inki.dae@samsung.com Cc: shirish@chromium.org List-Id: dri-devel@lists.freedesktop.org Hi Shirish, On 13.03.2014 06:28, Shirish S wrote: > Now that the drm_display_mode also provides aspect > ratio for all resolutions, this patch adds its usage > to set the active aspect ratio of AVI info frame > packets as per CEA-861-D standard's Table 9. > > This is also needed to abide by the 7-27 > compliance test of HDMI. > > Signed-off-by: Shirish S > --- > V2: rebased on new branch > V3: Incorporated review comments > > drivers/gpu/drm/exynos/exynos_hdmi.c | 35 +++++++++++++++++++++++++++------- > 1 file changed, 28 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c > index 12fdf55..9b0b617 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -53,12 +53,13 @@ > /* AVI header and aspect ratio */ > #define HDMI_AVI_VERSION 0x02 > #define HDMI_AVI_LENGTH 0x0D > -#define AVI_PIC_ASPECT_RATIO_16_9 (2 << 4) > -#define AVI_SAME_AS_PIC_ASPECT_RATIO 8 > > /* AUI header info */ > #define HDMI_AUI_VERSION 0x01 > #define HDMI_AUI_LENGTH 0x0A > +#define AVI_SAME_AS_PIC_ASPECT_RATIO 0x8 > +#define AVI_4_3_CENTER_RATIO 0x9 > +#define AVI_16_9_CENTER_RATIO 0xa One minor nitpick: Please don't use tabs between #define and macro name. After fixing this issue feel free to add my: Reviewed-by: Tomasz Figa Best regards, Tomasz