From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks Date: Tue, 18 Mar 2014 14:07:51 +0100 Message-ID: <53284527.8010903@samsung.com> References: <20140314140951.3d443a3096e80297c9fecef0@samsung.com> <5323078E.4060903@samsung.com> <20140318200329.cc1dca7541b4b1916e5d9d48@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sachin Kamat , Cho KyongHo Cc: Linux DeviceTree , Linux Samsung SOC , Prathyush , Grant Grundler , Linux Kernel , Linux IOMMU , Kukjin Kim , Sylwester Nawrocki , Varun Sethi , Antonios Motakis , Linux ARM Kernel , Rahul Sharma List-Id: iommu@lists.linux-foundation.org On 18.03.2014 12:18, Sachin Kamat wrote: > On 18 March 2014 16:33, Cho KyongHo wrote: >> On Fri, 14 Mar 2014 22:27:59 +0530, Sachin Kamat wrote: >>> Hi KyongHo, >>> >>> On 14 March 2014 19:13, Tomasz Figa wrote: >>>> Hi KyongHo, >>>> >>>> >>>> On 14.03.2014 06:09, Cho KyongHo wrote: >>>>> >>>>> exynos-iommu driver must care about master H/W's gate clock as well as >>>>> System MMU's gate clock. To enhance readability of the source code, >>>>> macros to gate/ungate those clocks are defined. >>>>> >>>>> Signed-off-by: Cho KyongHo >>>>> --- >>>>> drivers/iommu/exynos-iommu.c | 34 ++++++++++++++++++++++------------ >>>>> 1 file changed, 22 insertions(+), 12 deletions(-) >>>>> >>>>> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c >>>>> index 71e77f1..cef62d0 100644 >>>>> --- a/drivers/iommu/exynos-iommu.c >>>>> +++ b/drivers/iommu/exynos-iommu.c >>>>> @@ -101,6 +101,16 @@ >>>>> #define REG_PB1_SADDR 0x054 >>>>> #define REG_PB1_EADDR 0x058 >>>>> >>>>> +#define __clk_gate_ctrl(data, clk, en) do { \ >>>>> + if (data->clk) \ >>>>> + clk_##en##able(data->clk); \ >>>>> + } while (0) >>>>> + >>>>> +#define __sysmmu_clk_enable(data) __clk_gate_ctrl(data, clk, en) >>>>> +#define __sysmmu_clk_disable(data) __clk_gate_ctrl(data, clk, dis) >>>>> +#define __master_clk_enable(data) __clk_gate_ctrl(data, clk_master, >>>>> en) >>>>> +#define __master_clk_disable(data) __clk_gate_ctrl(data, clk_master, >>>>> dis) >>>>> + >>>> >>>> >>>> I'd say that such macros only obfuscate code, without any gains, as you can >>>> see in diffstat - this patch adds more lines than it removes. >>>> >>>> Please drop this change. >>> >>> I agree with Tomasz here. >>> >> >> Are you concerning about using macros or more insertions than deletions? > > It is just making the code more difficult to read and understand. Especially when hiding accesses to struct fields inside and doing fancy stuff like concatenations. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: t.figa@samsung.com (Tomasz Figa) Date: Tue, 18 Mar 2014 14:07:51 +0100 Subject: [PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks In-Reply-To: References: <20140314140951.3d443a3096e80297c9fecef0@samsung.com> <5323078E.4060903@samsung.com> <20140318200329.cc1dca7541b4b1916e5d9d48@samsung.com> Message-ID: <53284527.8010903@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 18.03.2014 12:18, Sachin Kamat wrote: > On 18 March 2014 16:33, Cho KyongHo wrote: >> On Fri, 14 Mar 2014 22:27:59 +0530, Sachin Kamat wrote: >>> Hi KyongHo, >>> >>> On 14 March 2014 19:13, Tomasz Figa wrote: >>>> Hi KyongHo, >>>> >>>> >>>> On 14.03.2014 06:09, Cho KyongHo wrote: >>>>> >>>>> exynos-iommu driver must care about master H/W's gate clock as well as >>>>> System MMU's gate clock. To enhance readability of the source code, >>>>> macros to gate/ungate those clocks are defined. >>>>> >>>>> Signed-off-by: Cho KyongHo >>>>> --- >>>>> drivers/iommu/exynos-iommu.c | 34 ++++++++++++++++++++++------------ >>>>> 1 file changed, 22 insertions(+), 12 deletions(-) >>>>> >>>>> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c >>>>> index 71e77f1..cef62d0 100644 >>>>> --- a/drivers/iommu/exynos-iommu.c >>>>> +++ b/drivers/iommu/exynos-iommu.c >>>>> @@ -101,6 +101,16 @@ >>>>> #define REG_PB1_SADDR 0x054 >>>>> #define REG_PB1_EADDR 0x058 >>>>> >>>>> +#define __clk_gate_ctrl(data, clk, en) do { \ >>>>> + if (data->clk) \ >>>>> + clk_##en##able(data->clk); \ >>>>> + } while (0) >>>>> + >>>>> +#define __sysmmu_clk_enable(data) __clk_gate_ctrl(data, clk, en) >>>>> +#define __sysmmu_clk_disable(data) __clk_gate_ctrl(data, clk, dis) >>>>> +#define __master_clk_enable(data) __clk_gate_ctrl(data, clk_master, >>>>> en) >>>>> +#define __master_clk_disable(data) __clk_gate_ctrl(data, clk_master, >>>>> dis) >>>>> + >>>> >>>> >>>> I'd say that such macros only obfuscate code, without any gains, as you can >>>> see in diffstat - this patch adds more lines than it removes. >>>> >>>> Please drop this change. >>> >>> I agree with Tomasz here. >>> >> >> Are you concerning about using macros or more insertions than deletions? > > It is just making the code more difficult to read and understand. Especially when hiding accesses to struct fields inside and doing fancy stuff like concatenations. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755759AbaCRNID (ORCPT ); Tue, 18 Mar 2014 09:08:03 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:32386 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755718AbaCRNH6 (ORCPT ); Tue, 18 Mar 2014 09:07:58 -0400 X-AuditID: cbfec7f5-b7fc96d000004885-95-5328452bca73 Message-id: <53284527.8010903@samsung.com> Date: Tue, 18 Mar 2014 14:07:51 +0100 From: Tomasz Figa Organization: Samsung R&D Institute Poland User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-version: 1.0 To: Sachin Kamat , Cho KyongHo Cc: Linux ARM Kernel , Linux DeviceTree , Linux IOMMU , Linux Kernel , Linux Samsung SOC , Antonios Motakis , Grant Grundler , Joerg Roedel , Kukjin Kim , Prathyush , Rahul Sharma , Sylwester Nawrocki , Varun Sethi Subject: Re: [PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks References: <20140314140951.3d443a3096e80297c9fecef0@samsung.com> <5323078E.4060903@samsung.com> <20140318200329.cc1dca7541b4b1916e5d9d48@samsung.com> In-reply-to: Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42I5/e/4NV1tV41gg1krNSzu3D3HajH/CJB4 deQHk8WC/dYWnbM3sFv0LrjKZrHp8TVWi8u75rBZzDi/j8niwoqN7Bb/eg8yWkxZdJjV4vCb dlaLk396GS1m3lrD4sDv8eTgPCaP2Q0XWTz+He5n8rhzbQ+bx+Yl9R6Tbyxn9OjbsorR4/Mm OY8rR88wBXBGcdmkpOZklqUW6dslcGWcP/abqWCFYMXcz19ZGhjP8nYxcnJICJhIvN3xihXC FpO4cG89WxcjF4eQwFJGiZWbrzFDOJ8ZJf61fwFyODh4BbQkev7mgzSwCKhK/Dr/kBnEZhNQ k/jc8IgNxOYHKlnTdJ0FxBYViJCYO3EzWJxXQFDix+R7YHERgQCJE7+XgM1nFrjOIvHs+C52 kISwQKTE3u4OqMUrmCS+7d8Bdh6nQLDEin9zmUBsZgFriZWTtjFC2PISm9e8ZZ7AKDgLyZJZ SMpmISlbwMi8ilE0tTS5oDgpPddIrzgxt7g0L10vOT93EyMk6r7uYFx6zOoQowAHoxIP70s2 9WAh1sSy4srcQ4wSHMxKIrzsVhrBQrwpiZVVqUX58UWlOanFhxiZODilGhglG0O3qWX3X7Pc bNoi+PXVz4UTwp9L3+y6dvAoq19BMhvraRGfozrqTVqb327J2XVjunCRm9/y972a7yWZz+27 xyhQnP34mq6LmobbldXzRQuYbijHChlPlj27NOy6hNFMo/4z26cETFwvt6gm8UqIY+6++PKV u1vLl86Pt5wRpPr07IHX1xcrsRRnJBpqMRcVJwIAE+xL4ZgCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.03.2014 12:18, Sachin Kamat wrote: > On 18 March 2014 16:33, Cho KyongHo wrote: >> On Fri, 14 Mar 2014 22:27:59 +0530, Sachin Kamat wrote: >>> Hi KyongHo, >>> >>> On 14 March 2014 19:13, Tomasz Figa wrote: >>>> Hi KyongHo, >>>> >>>> >>>> On 14.03.2014 06:09, Cho KyongHo wrote: >>>>> >>>>> exynos-iommu driver must care about master H/W's gate clock as well as >>>>> System MMU's gate clock. To enhance readability of the source code, >>>>> macros to gate/ungate those clocks are defined. >>>>> >>>>> Signed-off-by: Cho KyongHo >>>>> --- >>>>> drivers/iommu/exynos-iommu.c | 34 ++++++++++++++++++++++------------ >>>>> 1 file changed, 22 insertions(+), 12 deletions(-) >>>>> >>>>> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c >>>>> index 71e77f1..cef62d0 100644 >>>>> --- a/drivers/iommu/exynos-iommu.c >>>>> +++ b/drivers/iommu/exynos-iommu.c >>>>> @@ -101,6 +101,16 @@ >>>>> #define REG_PB1_SADDR 0x054 >>>>> #define REG_PB1_EADDR 0x058 >>>>> >>>>> +#define __clk_gate_ctrl(data, clk, en) do { \ >>>>> + if (data->clk) \ >>>>> + clk_##en##able(data->clk); \ >>>>> + } while (0) >>>>> + >>>>> +#define __sysmmu_clk_enable(data) __clk_gate_ctrl(data, clk, en) >>>>> +#define __sysmmu_clk_disable(data) __clk_gate_ctrl(data, clk, dis) >>>>> +#define __master_clk_enable(data) __clk_gate_ctrl(data, clk_master, >>>>> en) >>>>> +#define __master_clk_disable(data) __clk_gate_ctrl(data, clk_master, >>>>> dis) >>>>> + >>>> >>>> >>>> I'd say that such macros only obfuscate code, without any gains, as you can >>>> see in diffstat - this patch adds more lines than it removes. >>>> >>>> Please drop this change. >>> >>> I agree with Tomasz here. >>> >> >> Are you concerning about using macros or more insertions than deletions? > > It is just making the code more difficult to read and understand. Especially when hiding accesses to struct fields inside and doing fancy stuff like concatenations. Best regards, Tomasz