* [PATCH v2 2/2] xen: arm: fixup a couple of coding style issues
@ 2014-03-18 15:53 Ian Campbell
2014-03-18 16:01 ` Julien Grall
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2014-03-18 15:53 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
The if in domain.c was only syntactically valid because the macro happened to
contain enclosing braces.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/arch/arm/domain.c | 2 +-
xen/arch/arm/traps.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 0f83e81..8f91c2e 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -257,7 +257,7 @@ static void continue_new_vcpu(struct vcpu *prev)
if ( is_idle_vcpu(current) )
reset_stack_and_jump(idle_loop);
- else if is_32bit_domain(current->domain)
+ else if ( is_32bit_domain(current->domain) )
/* check_wakeup_from_wait(); */
reset_stack_and_jump(return_to_new_vcpu32);
else
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 563cc62..5d66bc4 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -1563,12 +1563,12 @@ asmlinkage void do_trap_hypervisor(struct cpu_user_regs *regs)
advance_pc(regs, hsr);
break;
case HSR_EC_CP15_32:
- if ( ! is_32bit_domain(current->domain) )
+ if ( !is_32bit_domain(current->domain) )
goto bad_trap;
do_cp15_32(regs, hsr);
break;
case HSR_EC_CP15_64:
- if ( ! is_32bit_domain(current->domain) )
+ if ( !is_32bit_domain(current->domain) )
goto bad_trap;
do_cp15_64(regs, hsr);
break;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/2] xen: arm: fixup a couple of coding style issues
2014-03-18 15:53 [PATCH v2 2/2] xen: arm: fixup a couple of coding style issues Ian Campbell
@ 2014-03-18 16:01 ` Julien Grall
2014-03-18 17:19 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2014-03-18 16:01 UTC (permalink / raw)
To: Ian Campbell; +Cc: stefano.stabellini, tim, xen-devel
On 03/18/2014 03:53 PM, Ian Campbell wrote:
> The if in domain.c was only syntactically valid because the macro happened to
> contain enclosing braces.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
> ---
> xen/arch/arm/domain.c | 2 +-
> xen/arch/arm/traps.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 0f83e81..8f91c2e 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -257,7 +257,7 @@ static void continue_new_vcpu(struct vcpu *prev)
>
> if ( is_idle_vcpu(current) )
> reset_stack_and_jump(idle_loop);
> - else if is_32bit_domain(current->domain)
> + else if ( is_32bit_domain(current->domain) )
> /* check_wakeup_from_wait(); */
> reset_stack_and_jump(return_to_new_vcpu32);
> else
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index 563cc62..5d66bc4 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -1563,12 +1563,12 @@ asmlinkage void do_trap_hypervisor(struct cpu_user_regs *regs)
> advance_pc(regs, hsr);
> break;
> case HSR_EC_CP15_32:
> - if ( ! is_32bit_domain(current->domain) )
> + if ( !is_32bit_domain(current->domain) )
> goto bad_trap;
> do_cp15_32(regs, hsr);
> break;
> case HSR_EC_CP15_64:
> - if ( ! is_32bit_domain(current->domain) )
> + if ( !is_32bit_domain(current->domain) )
> goto bad_trap;
> do_cp15_64(regs, hsr);
> break;
>
--
Julien Grall
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/2] xen: arm: fixup a couple of coding style issues
2014-03-18 16:01 ` Julien Grall
@ 2014-03-18 17:19 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2014-03-18 17:19 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, tim, stefano.stabellini
On Tue, 2014-03-18 at 16:01 +0000, Julien Grall wrote:
> On 03/18/2014 03:53 PM, Ian Campbell wrote:
> > The if in domain.c was only syntactically valid because the macro happened to
> > contain enclosing braces.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Acked-by: Julien Grall <julien.grall@linaro.org>
Thanks. Applied this and #1/2.
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-18 17:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-18 15:53 [PATCH v2 2/2] xen: arm: fixup a couple of coding style issues Ian Campbell
2014-03-18 16:01 ` Julien Grall
2014-03-18 17:19 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.