From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2 2/2] xen: arm: fixup a couple of coding
	style issues
Date: Tue, 18 Mar 2014 16:01:13 +0000
Message-ID: <53286DC9.4080004@linaro.org>
References: <1395158001-28085-2-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1395158001-28085-2-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 03/18/2014 03:53 PM, Ian Campbell wrote:
> The if in domain.c was only syntactically valid because the macro happened to
> contain enclosing braces.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
> ---
>  xen/arch/arm/domain.c |    2 +-
>  xen/arch/arm/traps.c  |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 0f83e81..8f91c2e 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -257,7 +257,7 @@ static void continue_new_vcpu(struct vcpu *prev)
>  
>      if ( is_idle_vcpu(current) )
>          reset_stack_and_jump(idle_loop);
> -    else if is_32bit_domain(current->domain)
> +    else if ( is_32bit_domain(current->domain) )
>          /* check_wakeup_from_wait(); */
>          reset_stack_and_jump(return_to_new_vcpu32);
>      else
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index 563cc62..5d66bc4 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -1563,12 +1563,12 @@ asmlinkage void do_trap_hypervisor(struct cpu_user_regs *regs)
>          advance_pc(regs, hsr);
>          break;
>      case HSR_EC_CP15_32:
> -        if ( ! is_32bit_domain(current->domain) )
> +        if ( !is_32bit_domain(current->domain) )
>              goto bad_trap;
>          do_cp15_32(regs, hsr);
>          break;
>      case HSR_EC_CP15_64:
> -        if ( ! is_32bit_domain(current->domain) )
> +        if ( !is_32bit_domain(current->domain) )
>              goto bad_trap;
>          do_cp15_64(regs, hsr);
>          break;
> 


-- 
Julien Grall