From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Julien Grall <julien.grall@linaro.org>,
tim@xen.org, stefano.stabellini@citrix.com
Subject: Re: [PATCH v2 14/15] xen/xsm: Add support for device tree
Date: Tue, 18 Mar 2014 17:34:38 +0000 [thread overview]
Message-ID: <532883AE.20604@citrix.com> (raw)
In-Reply-To: <1395163471.11824.41.camel@kazak.uk.xensource.com>
On 18/03/14 17:24, Ian Campbell wrote:
> On Mon, 2014-03-17 at 14:06 +0000, Julien Grall wrote:
>> This patch adds a new module "xen,xsm-blob" to allow the user to load the XSM
>> policy when Xen is booting.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>> Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>> +
>> + if ( policy_buffer )
>> + xfree(policy_buffer);
> Is xfree(NULL) not ok in the same way free(NULL) is?
xfree(NULL) is perfectly fine. The code should be tweaked.
~Andrew
next prev parent reply other threads:[~2014-03-18 17:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 14:05 [PATCH v2 00/15] Add support for XSM Julien Grall
2014-03-17 14:05 ` [PATCH v2 01/15] xen/arm: kernel: Don't hardcode flash address Julien Grall
2014-03-17 14:05 ` [PATCH v2 02/15] xen/arm: Remove the parameter "attrindx" in copy_from_paddr Julien Grall
2014-03-18 17:18 ` Ian Campbell
2014-03-17 14:05 ` [PATCH v2 03/15] xen/arm: Correctly define size_t Julien Grall
2014-03-17 14:05 ` [PATCH v2 04/15] xen/arm: next_module: Skip module if the size is 0 Julien Grall
2014-03-17 14:05 ` [PATCH v2 05/15] xen/xsm: xsm functions for PCI passthrough is not x86 specific Julien Grall
2014-03-17 14:05 ` [PATCH v2 06/15] xen/xsm: xsm_do_mca is " Julien Grall
2014-03-17 14:05 ` [PATCH v2 07/15] xen/xsm: flask: Fix compilation when CONFIG_COMPAT=n Julien Grall
2014-03-18 17:20 ` Ian Campbell
2014-03-17 14:05 ` [PATCH v2 08/15] xen/xsm: flask: Rename variable "bool" in "b" Julien Grall
2014-03-17 14:05 ` [PATCH v2 09/15] xen/xsm: flask: MSI is PCI specific Julien Grall
2014-03-18 17:22 ` Ian Campbell
2014-03-17 14:06 ` [PATCH v2 10/15] xen/xsm: flask: flask_copying_string is taking a XEN_GUEST_HANDLE as first param Julien Grall
2014-03-17 15:39 ` Jan Beulich
2014-03-17 15:46 ` Julien Grall
2014-03-17 16:33 ` Jan Beulich
2014-03-17 17:00 ` Stefano Stabellini
2014-03-17 14:06 ` [PATCH v2 11/15] xen/xsm: flask: Add missing header in hooks.c Julien Grall
2014-03-17 14:06 ` [PATCH v2 12/15] xen/xsm: Don't use multiboot by default to initialize XSM Julien Grall
2014-03-17 14:06 ` [PATCH v2 13/15] xen/xsm: Add xsm_core_init function Julien Grall
2014-03-18 17:23 ` Ian Campbell
2014-03-17 14:06 ` [PATCH v2 14/15] xen/xsm: Add support for device tree Julien Grall
2014-03-18 17:24 ` Ian Campbell
2014-03-18 17:34 ` Andrew Cooper [this message]
2014-03-18 20:52 ` Julien Grall
2014-03-17 14:06 ` [PATCH v2 15/15] xen/arm: Add support for XSM Julien Grall
2014-03-21 12:14 ` [PATCH v2 00/15] " Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532883AE.20604@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.