Re: [PATCH 2/3] libxl: hotplug scripts: stdout >& stderr

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 18/03/14 17:44, Ian Campbell wrote:
> On Tue, 2014-03-18 at 17:08 +0000, Ian Jackson wrote:
>> Plumb hotplug scripts' stdout to stderr.  That way if they print
>> anything (which really they shouldn't), it won't get mixed up with
>> the application's stdout.  (Eg, perhaps with an xl migration
>> stream...)
>>
>> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
>> CC: Roger Pau Monné <roger.pau@citrix.com>
>> CC: Vasiliy Tolstov <v.tolstov@selfip.ru>
>> CC: Ian Campbell <Ian.Campbell@citrix.com>
>> ---
>>  tools/libxl/libxl_device.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c
>> index ba7d100..90f76b7 100644
>> --- a/tools/libxl/libxl_device.c
>> +++ b/tools/libxl/libxl_device.c
>> @@ -1031,7 +1031,7 @@ static void device_hotplug(libxl__egc *egc, libxl__ao_device *aodev)
>>  
>>      if (!pid) {
>>          /* child */
>> -        libxl__exec(gc, -1, -1, -1, args[0], args, env);
>> +        libxl__exec(gc, -1, 2, -1, args[0], args, env);
> Do you think we should also put the script's stderr to the application's
> stderr?
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> as it stands.
>
> Ian.

Absolutely - anything on any stderr really needs to get to logs and
probably also to a human.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel