From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQ0yq-0003jN-Ev for qemu-devel@nongnu.org; Tue, 18 Mar 2014 16:51:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQ0yl-0003hl-I1 for qemu-devel@nongnu.org; Tue, 18 Mar 2014 16:51:24 -0400 Received: from mail-qg0-x22d.google.com ([2607:f8b0:400d:c04::22d]:63374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQ0yl-0003hd-Dh for qemu-devel@nongnu.org; Tue, 18 Mar 2014 16:51:19 -0400 Received: by mail-qg0-f45.google.com with SMTP id j5so22888702qga.4 for ; Tue, 18 Mar 2014 13:51:18 -0700 (PDT) Sender: Richard Henderson Message-ID: <5328B1C1.4070008@twiddle.net> Date: Tue, 18 Mar 2014 13:51:13 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1395170635-21281-1-git-send-email-peter.maydell@linaro.org> <1395170635-21281-2-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1395170635-21281-2-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH for-2.0 1/2] target-arm: A64: Add saturating int ops (SQNEG/SQABS) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Peter Crosthwaite , patches@linaro.org, Michael Matz , Alexander Graf , Will Newton , Dirk Mueller , Laurent Desnogues , =?UTF-8?B?QWxleCBCZW5uw6ll?= , kvmarm@lists.cs.columbia.edu, Christoffer Dall On 03/18/2014 12:23 PM, Peter Maydell wrote: > From: Alex Bennée > > This mostly re-uses the existing NEON helpers with an additional two for > the 64 bit case. I also took the opportunity to add TCG_CALL_NO_RWG > options to the helpers as they don't modify globals (saturation flags > are in the CPU Environment). > > Signed-off-by: Alex Bennée > Signed-off-by: Peter Maydell > --- > target-arm/helper.h | 14 +++++++------ > target-arm/neon_helper.c | 22 ++++++++++++++++++++ > target-arm/translate-a64.c | 51 ++++++++++++++++++++++++++++++++++++++++------ > 3 files changed, 75 insertions(+), 12 deletions(-) Reviewed-by: Richard Henderson r~