From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2 14/15] xen/xsm: Add support for device
 tree
Date: Tue, 18 Mar 2014 20:52:14 +0000
Message-ID: <5328B1FE.2090803@linaro.org>
References: <1395065165-15915-1-git-send-email-julien.grall@linaro.org>
	<1395065165-15915-15-git-send-email-julien.grall@linaro.org>
	<1395163471.11824.41.camel@kazak.uk.xensource.com>
	<532883AE.20604@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WQ0zh-0003WB-MI
	for xen-devel@lists.xenproject.org; Tue, 18 Mar 2014 20:52:17 +0000
Received: by mail-ee0-f46.google.com with SMTP id t10so5850728eei.33
	for <xen-devel@lists.xenproject.org>;
	Tue, 18 Mar 2014 13:52:16 -0700 (PDT)
In-Reply-To: <532883AE.20604@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Andrew and Ian,

On 03/18/2014 05:34 PM, Andrew Cooper wrote:
> On 18/03/14 17:24, Ian Campbell wrote:
>> On Mon, 2014-03-17 at 14:06 +0000, Julien Grall wrote:
>>> This patch adds a new module "xen,xsm-blob" to allow the user to load the XSM
>>> policy when Xen is booting.
>>>
>>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>>> Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>> +
>>> +    if ( policy_buffer )
>>> +        xfree(policy_buffer);
>> Is xfree(NULL) not ok in the same way free(NULL) is?
> 
> xfree(NULL) is perfectly fine.  The code should be tweaked.

I will remove the if in the next version.

Regards,

-- 
Julien Grall