From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?44Kr44Kq44CA44Of44Oz44CA44OS44Kn44OD44OX?= Date: Wed, 19 Mar 2014 00:50:51 +0000 Subject: Re: [RFC] spi: Using Trigger number to transmit/receive data Message-Id: <5328E9EB.2020809@jinso.co.jp> List-Id: References: <1394699364-5669-1-git-send-email-cm-hiep@jinso.co.jp> <1394699364-5669-2-git-send-email-cm-hiep@jinso.co.jp> <53264BA4.3000401@jinso.co.jp> <5326E424.9040709@jinso.co.jp> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Geert Uytterhoeven Cc: Mark Brown , "devicetree@vger.kernel.org" , Linux-sh list , Kuninori Morimoto , Geert Uytterhoeven Hi Geert On 03/18/2014 04:48 AM, Geert Uytterhoeven wrote: > Hi Hiep, > > On Mon, Mar 17, 2014 at 1:01 PM, カオ　ミン　ヒェップ wrote: >> On 03/17/2014 04:54 PM, Geert Uytterhoeven wrote: >>> On Mon, Mar 17, 2014 at 2:11 AM, カオ　ミン　ヒェップ wrote: >>>> On 03/13/2014 06:23 PM, Geert Uytterhoeven wrote: >>>>> On Thu, Mar 13, 2014 at 9:29 AM, Cao Minh Hiep >>>>> wrote: >>>>>> In order to transmit and receive data when have 32 bytes of data that >>>>>> ready has prepared on Transmit/Receive Buffer to transmit or receive. >>>>>> Instead transmits/receives a byte data using Transmit/Receive Buffer >>>>>> Data Triggering Number will improve the speed of transfer data. >>>>> Thanks for your patch, this looks like a valuable improvement! >>>>> >>>>> Unfortunately your patch doesn't apply against spi/for-next anymore, as >>>>> the driver has changed a lot lately, due to the addition of RZ/A1H and >>>>> Quad/Dual support. >>>>> >>>> Thanks, Do you mean this patch did not need for next and I don't mind >>>> about >>>> it? >>> It means you will have to rework your patch to apply on top of >>> >>> https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/tree/drivers/spi?h=for-next >>> before the SPI maintainer can accept it. >> Thanks, I understood, I will rework my patch and report to your later. > I gave your patch a try on a v3.14-rc5 kernel on r8a7791/Koelsch, > and it increased Single SPI read transfer speed from ca. 1 Mbps to 11 Mbps. > So I'm looking forward to an updated version. Thanks, I am modifying my patch and will send it to you as soon as possible. Hiep From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?44Kr44Kq44CA44Of44Oz44CA44OS44Kn44OD44OX?= Subject: Re: [RFC] spi: Using Trigger number to transmit/receive data Date: Wed, 19 Mar 2014 09:50:51 +0900 Message-ID: <5328E9EB.2020809@jinso.co.jp> References: <1394699364-5669-1-git-send-email-cm-hiep@jinso.co.jp> <1394699364-5669-2-git-send-email-cm-hiep@jinso.co.jp> <53264BA4.3000401@jinso.co.jp> <5326E424.9040709@jinso.co.jp> Reply-To: cm-hiep@jinso.co.jp Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Mark Brown , "devicetree@vger.kernel.org" , Linux-sh list , Kuninori Morimoto , Geert Uytterhoeven List-Id: devicetree@vger.kernel.org Hi Geert On 03/18/2014 04:48 AM, Geert Uytterhoeven wrote: > Hi Hiep, > > On Mon, Mar 17, 2014 at 1:01 PM, =E3=82=AB=E3=82=AA=E3=80=80=E3=83=9F= =E3=83=B3=E3=80=80=E3=83=92=E3=82=A7=E3=83=83=E3=83=97 wrote: >> On 03/17/2014 04:54 PM, Geert Uytterhoeven wrote: >>> On Mon, Mar 17, 2014 at 2:11 AM, =E3=82=AB=E3=82=AA=E3=80=80=E3=83=9F= =E3=83=B3=E3=80=80=E3=83=92=E3=82=A7=E3=83=83=E3=83=97 wrote: >>>> On 03/13/2014 06:23 PM, Geert Uytterhoeven wrote: >>>>> On Thu, Mar 13, 2014 at 9:29 AM, Cao Minh Hiep >>>>> wrote: >>>>>> In order to transmit and receive data when have 32 bytes of data= that >>>>>> ready has prepared on Transmit/Receive Buffer to transmit or rec= eive. >>>>>> Instead transmits/receives a byte data using Transmit/Receive Bu= ffer >>>>>> Data Triggering Number will improve the speed of transfer data. >>>>> Thanks for your patch, this looks like a valuable improvement! >>>>> >>>>> Unfortunately your patch doesn't apply against spi/for-next anymo= re, as >>>>> the driver has changed a lot lately, due to the addition of RZ/A1= H and >>>>> Quad/Dual support. >>>>> >>>> Thanks, Do you mean this patch did not need for next and I don't m= ind >>>> about >>>> it? >>> It means you will have to rework your patch to apply on top of >>> >>> https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/tree/d= rivers/spi?h=3Dfor-next >>> before the SPI maintainer can accept it. >> Thanks, I understood, I will rework my patch and report to your late= r. > I gave your patch a try on a v3.14-rc5 kernel on r8a7791/Koelsch, > and it increased Single SPI read transfer speed from ca. 1 Mbps to 11= Mbps. > So I'm looking forward to an updated version. Thanks, I am modifying my patch and will send it to you as soon as poss= ible. Hiep