From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, fweisbec@gmail.com, mingo@redhat.com
Subject: Re: [PATCH 1/3 Resend] tracing: Use inline task_nice() to get rid of an open coded implementation of it.
Date: Wed, 19 Mar 2014 10:20:08 +0800 [thread overview]
Message-ID: <5328FED8.7090007@cn.fujitsu.com> (raw)
In-Reply-To: <20140318221533.45c479bd@gandalf.local.home>
On 03/19/2014 10:15 AM, Steven Rostedt wrote:
> On Wed, 12 Mar 2014 18:26:42 +0800
> Dongsheng Yang <yangds.fnst@cn.fujitsu.com> wrote:
>
>> Function task_nice() was reimplemented as inline function, we can use it here
>> to replace the open coded implementation.
>>
>> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
>> cc: Steven Rostedt <rostedt@goodmis.org>
>> ---
>> kernel/trace/trace.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
>> index 815c878..dba0e3d 100644
>> --- a/kernel/trace/trace.c
>> +++ b/kernel/trace/trace.c
>> @@ -1003,7 +1003,7 @@ __update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
>> else
>> max_data->uid = task_uid(tsk);
>>
>> - max_data->nice = tsk->static_prio - 20 - MAX_RT_PRIO;
>> + max_data->nice = task_nice(tsk);
> task_nice() is still an extern function in mainline, and this is the
> tracing side. I rather wait till it becomes inline in Linus's tree
> before I take this.
Sounds reasonable to me.
Thanx.
>
> -- Steve
>
>> max_data->policy = tsk->policy;
>> max_data->rt_priority = tsk->rt_priority;
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2014-03-19 2:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 10:26 [PATCH 0/3 for-tip] use task_nice() in tracing to git rid of an open coded impolementation of it Dongsheng Yang
2014-03-12 10:26 ` [PATCH 1/3 Resend] tracing: Use inline task_nice() to get rid of an open coded implementation " Dongsheng Yang
2014-03-19 2:15 ` Steven Rostedt
2014-03-19 2:20 ` Dongsheng Yang [this message]
2014-05-08 6:38 ` [PATCH RESEND] " Dongsheng Yang
2014-05-09 0:17 ` Dongsheng Yang
2014-05-09 1:23 ` Steven Rostedt
2014-03-12 10:26 ` [PATCH 2/3] sched/prio: Replace hardcoding of 40 with NICE_WIDTH Dongsheng Yang
2014-03-12 10:26 ` [PATCH 3/3] sched: Use clamp() and clamp_val() to make it more readable Dongsheng Yang
2014-03-19 2:16 ` Steven Rostedt
2014-03-19 2:19 ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5328FED8.7090007@cn.fujitsu.com \
--to=yangds.fnst@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.