From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQFm8-00067R-MH for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:39:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQFm4-0000ez-GL for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:39:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQFm4-0000ep-8D for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:39:12 -0400 Message-ID: <53298FE7.6000401@redhat.com> Date: Wed, 19 Mar 2014 06:39:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1395221519-893471-1-git-send-email-anton.ivanov@kot-begemot.co.uk> In-Reply-To: <1395221519-893471-1-git-send-email-anton.ivanov@kot-begemot.co.uk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CceAItlThjMJAbmPh8068FDTofnTArtCQ" Subject: Re: [Qemu-devel] [PATCH v4] net: L2TPv3 transport List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anton.ivanov@kot-begemot.co.uk, qemu-devel@nongnu.org Cc: Anton Ivanov , pbonzini@redhat.com, afaerber@suse.de, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CceAItlThjMJAbmPh8068FDTofnTArtCQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/19/2014 03:31 AM, anton.ivanov@kot-begemot.co.uk wrote: > From: Anton Ivanov >=20 > This tranport allows to connect a qemu nic to a static Ethernet s/tranport/transport/ > over L2TPv3 tunnel. The transport supports all options present > in the linux kernel implementation. It allows qemu to connect > to any linux host running kernel 3.3+, most routers and network > devices as well as other qemu instances. >=20 > Signed-off-by: Anton Ivanov > --- >=20 > +++ b/qapi-schema.json > @@ -2941,6 +2941,63 @@ > '*udp': 'str' } } > =20 > ## > +# @NetdevL2TPv3Options > +# > +# Connect the VLAN to Ethernet over L2TPv3 Static tunnel > +# > +# @src: source address > +# > +# @dst: destination address > +# > +# > +# @txsession: 32 bit transmit session > +# > +# @rxsession: 32 bit receive session - if not specified > +# set to the same value as transmit Missing #optional on rxsession. > +# > +# @offset: #optional additional offset - allows the insertion of > +# additional application-specific data before the packet payl= oad > +# > +# Since 2.0 You've missed 2.0; this should be 2.1. > + > +## > +## > # @NetdevVdeOptions No need to add a second line of ## to NetdevVdeOptions. > # > # Connect the VLAN to a vde switch running on the host. > @@ -3014,13 +3071,16 @@ > # A discriminated record of network device traits. > # > # Since 1.2 > -## > +# > +# Added in 2.0 - l2tpv3 2.1 > +#ifdef __linux__ > + "-net l2tpv3[,vlan=3Dn][,name=3Dstr],src=3Dsrcaddr,dst=3Ddstaddr[,= srcport=3Dsrcport][,dstport=3Ddstport],txsession=3Dtxsession[,rxsession=3D= rxsession][,ipv6=3Don/off][,udp=3Don/off][,cookie64=3Don/off][,counter][,= pincounter][,txcookie=3Dtxcookie][,rxcookie=3Drxcookie][,offset=3Doffset]= \n" > + " connect the VLAN to an Ethernet over L2TPv3 pseud= owire\n" > + " Linux kernel 3.3+ as well as most routers can tal= k \n" Trailing whitespace in the output. > + " L2TPv3. This transport allows to connect a VM to = a VM,\n" > + " VM to a router and even VM to Host. It is a nearl= y-universal\n" > + " standard (RFC3391). Note - this implementation us= es static\n" > + " pre-configured tunnels (same as the linux kernel)= =2E \n" and again > @@ -1408,11 +1431,11 @@ DEF("net", HAS_ARG, QEMU_OPTION_net, > " on host and listening for incoming connections on= 'socketpath'.\n" > " Use group 'groupname' and mode 'octalmode' to cha= nge default\n" > " ownership and permissions for communication port.= \n" > -#endif > "-net dump[,vlan=3Dn][,file=3Df][,len=3Dn]\n" > " dump traffic on vlan 'n' to file 'f' (max n bytes= per packet)\n" > "-net none use it alone to have zero network devices. If no = -net option\n" > " is provided, the default is '-net nic -net user'\= n", QEMU_ARCH_ALL) > +#endif Why is this #endif moving? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CceAItlThjMJAbmPh8068FDTofnTArtCQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTKY/nAAoJEKeha0olJ0NqAXkH/jgOvrS3uVD59D/mR+26iOyR zz1ehNhlXzh4lKP3H+8Wtfs+0GF/EyyorUFiqU7U+++zbXL3O4/v2Pq0qGgAJfnV zjDyGb3cSscViEBfqVwJgNcNuQaxJ0qQ8AD16VF4bAAPCYyvNhay4LnCjzOtFc2t eQdHcFE4jm67kQ8P6xYKk5hsH3AnXsvE74D5OyxWQdmJCJ1cQseG9q5WaPQQQId4 u85Wk40dl9lS0xXNsS9yrN0MOcRdkTYnP0nPvA5CRFldQOSdkNr0RfrwDIH9jvCg l1hD0PVLNQZlQ5805bi3HGFcGK87rpDgTcgTp9UpfgMtqn09OdnboViJ8jUl3Fw= =B3Th -----END PGP SIGNATURE----- --CceAItlThjMJAbmPh8068FDTofnTArtCQ--