Re: [PATCH RFC] drm: Make the drm_vma_manager authentication mechanism a bit more versatile

[Thomas Hellstrom <thomas@shipmail.org>]

On 03/19/2014 12:45 PM, David Herrmann wrote:
> Hi
>
> On Wed, Mar 19, 2014 at 12:33 PM, Thomas Hellstrom
> <thellstrom@vmware.com> wrote:
>> By handing the authentication mechanism tokens in the form of const void
>> pointers instead of struct file pointers, drivers are free to provide whatever
>> file pointers they find appropriate. The pointers are never dereferenced in
>> the drm_vma_manager so that shouldn't be a problem.
>>
>> As an example, the vmwgfx driver would like to provide struct ttm_object_file
>> pointers.
> I guess a "struct file*" pointer in tmm_object_file would be easier,
> but if that reverse dependency is not wanted, I'm fine with that. Just
> make sure you don't use drm_vma_node_verify_access for TTM directly as
> TTM passes in a file pointer.
>
> Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
>
> Thanks
> David

Thanks for reviewing, David.

Although it turned out that I won't be needing this, ATM
since the TTM object mechanism already has a per file object-to-handle
mapping that I could reuse for this.

Thanks,
Thomas