From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] Coverity: Fix failure path for qemu_accept in migration
Date: Wed, 19 Mar 2014 13:40:06 +0100 [thread overview]
Message-ID: <53299026.1080905@redhat.com> (raw)
In-Reply-To: <20140319113429.GG2371@work-vm>
Il 19/03/2014 12:34, Dr. David Alan Gilbert ha scritto:
>>> > > + fprintf(stderr, "could not accept migration connection (%d)\n", err);
>> >
>> > Bit unfriendly not to convert the errno to a string.
> I could reroll it with a strerror.
Since you are at it, please use error_report too.
Paolo
prev parent reply other threads:[~2014-03-19 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 11:13 [Qemu-devel] [PATCH 1/1] Coverity: Fix failure path for qemu_accept in migration Dr. David Alan Gilbert (git)
2014-03-19 11:23 ` Peter Maydell
2014-03-19 11:34 ` Dr. David Alan Gilbert
2014-03-19 12:01 ` Markus Armbruster
2014-03-19 12:40 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53299026.1080905@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.