From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH V3] xen/balloon: flush persistent kmaps in correct position Date: Wed, 19 Mar 2014 13:32:45 +0000 Message-ID: <53299C7D.3030905@citrix.com> References: <1394899907-2529-1-git-send-email-wei.liu2@citrix.com> <20140318134728.GA16807@zion.uk.xensource.com> <53288527.8070003@citrix.com> <20140319111920.GC16807@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WQGc4-0007Sx-2y for xen-devel@lists.xenproject.org; Wed, 19 Mar 2014 13:32:56 +0000 In-Reply-To: <20140319111920.GC16807@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky , David Vrabel List-Id: xen-devel@lists.xenproject.org On 19/03/14 11:19, Wei Liu wrote: > On Tue, Mar 18, 2014 at 05:40:55PM +0000, David Vrabel wrote: > [...] >> Wei, how about this? I expanded the comment, left the tlb flush after >> changing the mappings, and shuffled a few bits around to avoid a few >> pfn/mfn/page conversions. >> >> Can you test it, please? >> > > Yes, I tested it on 32-bit PV and it worked. I manually copied and > pasted the changes. Applied to stable/for-linus-3.14. Thanks. >> @@ -399,12 +399,26 @@ static enum bp_state decrease_reservation(unsigned >> long nr_pages, gfp_t gfp) > > FYI, This line was wrapped by your email client. Sorry, forgot to disable word wrapping. David