From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH v4 14/15] xenctx: Add output of vcpu value
 and state for --all-vcpus
Date: Wed, 19 Mar 2014 09:36:31 -0400
Message-ID: <53299D5F.5090004@terremark.com>
References: <1395180940-23901-1-git-send-email-dslutz@verizon.com>
	<1395180940-23901-15-git-send-email-dslutz@verizon.com>
	<5329642A02000078001258B9@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5329642A02000078001258B9@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Don Slutz <dslutz@verizon.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, xen-devel@lists.xen.org, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 03/19/14 04:32, Jan Beulich wrote:
>>>> On 18.03.14 at 23:15, Don Slutz <dslutz@verizon.com> wrote:
>> --- a/tools/xentrace/xenctx.c
>> +++ b/tools/xentrace/xenctx.c
>> @@ -1046,8 +1046,13 @@ static void dump_all_vcpus(void)
>>       {
>>           if ( xc_vcpu_getinfo(xenctx.xc_handle, xenctx.domid, vcpu, &vinfo) )
>>               continue;
>> -        if ( vinfo.online )
>> +        if ( vinfo.online ) {
>> +            printf("vcpu=%d online\n", vcpu);
> I'd drop the "=" here (and below), and omit the "online" (but keep
> the "offline" below), perhaps in favor of a ":".

Will do.

    -Don Slutz

> Jan
>