Re: [PATCH 0/4] MIPS: KVM: RI + RDHWR handling fixes

[Paolo Bonzini <pbonzini@redhat.com>]

Il 14/03/2014 14:06, James Hogan ha scritto:
> Some misc KVM RI/RDHWR handling fixes.
>
> Patch 1 prevents a reserved instruction (RI) exception from taking out
> the entire guest (e.g. crashme inevitably causes lots of these). If the
> hypervisor can't handle the RI, it can just emulate a guest RI exception
> instead so the guest OS can handle it. I've marked this one for stable
> since it allows guest userland to take out the VM.
>
> Patch 3 fixes the RDHWR emulation to actually consult HWREna so that the
> guest can catch exceptions of implemented RDHWR if it desires. I've not
> marked this for stable since Linux at least enables the hardware
> registers with HWREna anyway.
>
> Patch 2 and 4 are cleanups that I noticed while writing patch 3.
>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Gleb Natapov <gleb@kernel.org>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Sanjay Lal <sanjayl@kymasys.com>
> Cc: linux-mips@linux-mips.org
> Cc: kvm@vger.kernel.org
>
> James Hogan (4):
>   MIPS: KVM: Pass reserved instruction exceptions to guest
>   MIPS: KVM: asm/kvm_host.h: Clean up whitespace
>   MIPS: KVM: Consult HWREna before emulating RDHWR
>   MIPS: KVM: Remove dead code in CP0 emulation
>
>  arch/mips/include/asm/kvm_host.h | 417 ++++++++++++++++++++-------------------
>  arch/mips/kvm/kvm_mips_emul.c    |  40 ++--
>  2 files changed, 229 insertions(+), 228 deletions(-)
>

Looks good.  I've applied it to kvm/queue, having a Reviewed-by or 
Acked-by from the MIPS folks would be nice too.

Paolo