From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Date: Wed, 19 Mar 2014 16:15:20 +0000 Subject: Re: [RFC 4/6] ARM: shmobile: r8a7790: call sh_pm_runtime_init() Message-Id: <5329C298.6050002@codethink.co.uk> List-Id: References: <1395054917-27390-5-git-send-email-ben.dooks@codethink.co.uk> In-Reply-To: <1395054917-27390-5-git-send-email-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On 19/03/14 17:10, Geert Uytterhoeven wrote: > Hi Ben, > > On Mon, Mar 17, 2014 at 12:15 PM, Ben Dooks wrote: >> Ensure pm_runtime is initialised. >> >> Signed-off-by: Ben Dooks >> --- >> arch/arm/mach-shmobile/setup-r8a7790.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/mach-shmobile/setup-r8a7790.c b/arch/arm/mach-shmobile/setup-r8a7790.c >> index c4616f0..8424cb4 100644 >> --- a/arch/arm/mach-shmobile/setup-r8a7790.c >> +++ b/arch/arm/mach-shmobile/setup-r8a7790.c >> @@ -305,6 +305,7 @@ void __init r8a7790_add_dt_devices(void) >> >> void __init r8a7790_add_standard_devices(void) >> { >> + sh_pm_runtime_init(); >> r8a7790_add_dt_devices(); >> r8a7790_register_irqc(0); >> r8a7790_register_thermal(); > > Are you sure this is the right function? > r8a7790_add_standard_devices() is only called from board-lager.c, > not from board-lager-reference.c. > > I'd expect it to be added to r8a7790_add_dt_devices(). Thanks, I only put this out as an RFC, not had time to do a full test yet. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius