From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 1/4] xen: arm: clarify naming of the Xen TLB flushing functions Date: Wed, 19 Mar 2014 21:10:03 +0000 Message-ID: <532A07AB.4030804@linaro.org> References: <1395064315.18221.26.camel@kazak.uk.xensource.com> <1395064352-2128-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1395064352-2128-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 03/17/2014 01:52 PM, Ian Campbell wrote: > All of the flush_xen_*_tlb functions operate on the local processor only. Add > _local to the name and update the comments to clarify. You forgot to replace one flush_xen_data_tlb_range_va in setup_pagetables: mm.c: In function 'setup_pagetables': mm.c:425:5: error: implicit declaration of function 'flush_xen_data_tlb_range_va' [-Werror=implicit-function-declaration] mm.c:425:5: error: nested extern declaration of 'flush_xen_data_tlb_range_va' [-Werror=nested-externs] Regards, -- Julien Grall