From: Julien Grall <julien.grall@linaro.org>
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
ian.campbell@citrix.com, stefano.stabellini@citrix.com
Subject: Re: [PATCH] xen/arm: Guard correctly asm-arm/platforms/exynos5.h
Date: Wed, 19 Mar 2014 21:27:03 +0000 [thread overview]
Message-ID: <532A0BA7.4020405@linaro.org> (raw)
In-Reply-To: <1395264146-12698-1-git-send-email-julien.grall@linaro.org>
On 03/19/2014 09:22 PM, Julien Grall wrote:
> Fix compilation with clang 3.5:
>
> /local/home/julien/works/arndale/xen/xen/include/asm/platforms/exynos5.h:1:9: error: '__ASM_ARM_PLATFORMS_EXYNOS5_H' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard]
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /local/home/julien/works/arndale/xen/xen/include/asm/platforms/exynos5.h:2:9: note: '__ASM_ASM_PLATFORMS_EXYSNO5_H' is defined here; did you mean '__ASM_ARM_PLATFORMS_EXYNOS5_H'?
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> __ASM_ARM_PLATFORMS_EXYNOS5_H
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> ---
> xen/include/asm-arm/platforms/exynos5.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/include/asm-arm/platforms/exynos5.h b/xen/include/asm-arm/platforms/exynos5.h
> index af30608..2f0866d 100644
> --- a/xen/include/asm-arm/platforms/exynos5.h
> +++ b/xen/include/asm-arm/platforms/exynos5.h
> @@ -1,5 +1,5 @@
> #ifndef __ASM_ARM_PLATFORMS_EXYNOS5_H
> -#define __ASM_ASM_PLATFORMS_EXYSNO5_H
> +#define __ASM_ARM_PLATFORMS_EXYSNO5_H
Actually there was 2 errors in guard. I have sent another version.
--
Julien Grall
prev parent reply other threads:[~2014-03-19 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 21:22 [PATCH] xen/arm: Guard correctly asm-arm/platforms/exynos5.h Julien Grall
2014-03-19 21:27 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532A0BA7.4020405@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.