Re: [Qemu-devel] [PATCH RESEND v4 4/5] qom: add check() argument to object_property_add_link()

["Andreas Färber" <afaerber@suse.de>]

Am 19.03.2014 08:58, schrieb Stefan Hajnoczi:
> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> index 3c000ee..68aaed6 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -204,4 +204,15 @@ void qdev_property_add_static(DeviceState *dev, Property *prop, Error **errp);
>   */
>  void qdev_prop_set_after_realize(DeviceState *dev, const char *name,
>                                   Error **errp);
> +
> +/**
> + * @qdev_prop_allow_set_link_before_realize:
> + *
> + * Set the Error object if an attempt is made to set the link after realize.
> + * This function should be used as the check() argument to
> + * object_property_add_link().
> + */
> +void qdev_prop_allow_set_link_before_realize(Object *obj, const char *name,
> +                                             Object *val, Error **errp);
> +
>  #endif

This is copying a bad example ... no @ before function name, as done
correctly in object.h. Fixed.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg