From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQPHc-0002e1-CX for qemu-devel@nongnu.org; Wed, 19 Mar 2014 18:48:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQPHU-00066E-QM for qemu-devel@nongnu.org; Wed, 19 Mar 2014 18:48:24 -0400 Message-ID: <532A1E77.6050000@web.de> Date: Wed, 19 Mar 2014 23:47:19 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <5327541D.3020709@web.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 09/10] raven: fix PCI bus accesses with size > 1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Artyom Tarasenko Cc: Mark Cave-Ayland , qemu-ppc@nongnu.org, qemu-devel , =?ISO-8859-1?Q?Herv=E9_Poussineau?= Am 17.03.2014 22:55, schrieb Artyom Tarasenko: > Hi Andreas, > > On Mon, Mar 17, 2014 at 8:59 PM, Andreas Färber wrote: >>> this patch seems still be missing in master. Is it causing any problems? >> >> It does not apply without the preceding patches. Here's my cherry-pick >> result: >> [...] >> I.e. we might change 1 -> 4 in the SysBus API, but would that work given >> that endianness is being changed alongside? > > Yes, and that's the point of this patch. PCI configuration space is > little-endian. With 1 byte access size, no byte swapping happens, so > the bug is hidden. > But on 32- and 16- bit accesses the bytes are swapped. I think you misunderstood my question: I wanted to know whether switching from SysBus API to pure MemoryRegion API was part of the fix or an independent cleanup. But now that I'm going through the respun series it doesn't really matter any more... Andreas