From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758906AbaCSWUU (ORCPT ); Wed, 19 Mar 2014 18:20:20 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:49918 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756314AbaCSWUR (ORCPT ); Wed, 19 Mar 2014 18:20:17 -0400 Message-ID: <532A262B.803@cogentembedded.com> Date: Thu, 20 Mar 2014 02:20:11 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Jason Gunthorpe , Rob Herring CC: Rob Herring , Florian Fainelli , "David S. Miller" , "linux-kernel@vger.kernel.org" , netdev Subject: Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing References: <1394658311-17769-1-git-send-email-jgunthorpe@obsidianresearch.com> <1394658311-17769-2-git-send-email-jgunthorpe@obsidianresearch.com> <20140319221404.GA1154@obsidianresearch.com> In-Reply-To: <20140319221404.GA1154@obsidianresearch.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 03/20/2014 01:14 AM, Jason Gunthorpe wrote: >> The preferred multi-line comment style is: >> /* >> * bla >> * bla >> */ > Sergei, the entire file use the 'net' multi-line commenting style, and > I have maintined that consistency with the new code. No, you haven't followed the networking style. It is: /* bla * bla */ while your comment used: /* bla * bla */ > v3 on its way. > Regards, > Jason WBR, Sergei