From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pankaj Dubey Subject: Re: [PATCH v2 1/4] clk: samsung: add new Kconfig for Samsung common clock options Date: Thu, 20 Mar 2014 13:27:11 +0900 Message-ID: <532A6E1F.3040700@samsung.com> References: <1394598781-3848-1-git-send-email-pankaj.dubey@samsung.com> <1394598781-3848-2-git-send-email-pankaj.dubey@samsung.com> <53298B63.40005@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <53298B63.40005@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Tomasz Figa Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org On 03/19/2014 09:19 PM, Tomasz Figa wrote: > Hi Pankaj, > > On 12.03.2014 05:32, Pankaj Dubey wrote: >> This patch adds new Kconfig file for adding new config option >> as COMMON_CLK_SAMSUNG for Samsung common clock. This patch also >> moves S3C24XX specific clock options here in this file. >> >> Signed-off-by: Pankaj Dubey >> --- >> drivers/clk/samsung/Kconfig | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> create mode 100644 drivers/clk/samsung/Kconfig >> >> diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig >> new file mode 100644 >> index 0000000..26eb446 >> --- /dev/null >> +++ b/drivers/clk/samsung/Kconfig >> @@ -0,0 +1,11 @@ >> +config COMMON_CLK_SAMSUNG >> + bool >> + select COMMON_CLK >> + >> +config S3C2412_COMMON_CLK >> + bool >> + select COMMON_CLK_SAMSUNG >> + >> +config S3C2443_COMMON_CLK >> + bool >> + select COMMON_CLK_SAMSUNG >> > > This patch adds S3C2412_COMMON_CLK and S3C2443_COMMON_CLK to > drivers/clk/samsung/Kconfig, but they are still present in > arch/arm/mach-s3c24xx/Kconfig, so after this patch there are duplicate > definitions. > > Best regards, > Tomasz > OK, In that case I will club change in arm/mach-s3c24xx/Kconfig and clk/samsung/Kconfig together and resubmit once again. -- Best Regards, Pankaj Dubey From mboxrd@z Thu Jan 1 00:00:00 1970 From: pankaj.dubey@samsung.com (Pankaj Dubey) Date: Thu, 20 Mar 2014 13:27:11 +0900 Subject: [PATCH v2 1/4] clk: samsung: add new Kconfig for Samsung common clock options In-Reply-To: <53298B63.40005@samsung.com> References: <1394598781-3848-1-git-send-email-pankaj.dubey@samsung.com> <1394598781-3848-2-git-send-email-pankaj.dubey@samsung.com> <53298B63.40005@samsung.com> Message-ID: <532A6E1F.3040700@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/19/2014 09:19 PM, Tomasz Figa wrote: > Hi Pankaj, > > On 12.03.2014 05:32, Pankaj Dubey wrote: >> This patch adds new Kconfig file for adding new config option >> as COMMON_CLK_SAMSUNG for Samsung common clock. This patch also >> moves S3C24XX specific clock options here in this file. >> >> Signed-off-by: Pankaj Dubey >> --- >> drivers/clk/samsung/Kconfig | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> create mode 100644 drivers/clk/samsung/Kconfig >> >> diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig >> new file mode 100644 >> index 0000000..26eb446 >> --- /dev/null >> +++ b/drivers/clk/samsung/Kconfig >> @@ -0,0 +1,11 @@ >> +config COMMON_CLK_SAMSUNG >> + bool >> + select COMMON_CLK >> + >> +config S3C2412_COMMON_CLK >> + bool >> + select COMMON_CLK_SAMSUNG >> + >> +config S3C2443_COMMON_CLK >> + bool >> + select COMMON_CLK_SAMSUNG >> > > This patch adds S3C2412_COMMON_CLK and S3C2443_COMMON_CLK to > drivers/clk/samsung/Kconfig, but they are still present in > arch/arm/mach-s3c24xx/Kconfig, so after this patch there are duplicate > definitions. > > Best regards, > Tomasz > OK, In that case I will club change in arm/mach-s3c24xx/Kconfig and clk/samsung/Kconfig together and resubmit once again. -- Best Regards, Pankaj Dubey