From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 3C730E00995 for ; Thu, 20 Mar 2014 01:59:36 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 20 Mar 2014 01:55:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,693,1389772800"; d="scan'208,217";a="495691583" Received: from mavram-vostro.rb.intel.com (HELO [10.237.105.158]) ([10.237.105.158]) by fmsmga001.fm.intel.com with ESMTP; 20 Mar 2014 01:59:33 -0700 Message-ID: <532AAF26.9050600@intel.com> Date: Thu, 20 Mar 2014 11:04:38 +0200 From: Marius Avram User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: "Damian, Alexandru" References: <1395145971-14958-1-git-send-email-marius.avram@intel.com> <07B306F671A2A440AD6917C2839B2036F3A651@IRSMSX102.ger.corp.intel.com> In-Reply-To: Cc: "toaster@yoctoproject.org" Subject: Re: [PATCH] toaster: full path in variable history X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Mar 2014 08:59:39 -0000 Content-Type: multipart/alternative; boundary="------------020401050205060905080701" --------------020401050205060905080701 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I've made a build for core-image-minimal on top of commit master:3c70ad664685716d8d805aebf211daff4a062d1a with my patch applied inside a new build directory and I can confirm that the building process finished successfully. On 03/18/2014 05:40 PM, Damian, Alexandru wrote: > Please validate that the reading of the config files is not affected > by deleting the recipe cache and trying to build from scratch. > This change cascades into the ast parser, not just logging and > variable history. > > Alex > > > On Tue, Mar 18, 2014 at 3:15 PM, Avram, Marius > wrote: > > I only tested if the file_name fields from VariableHistory model > is filled correctly by accessing: > http://localhost:8000/api/1.0/variablehistory which returns a > JSON of the table. > > I thought that replacing a relative path with an absolute path > will not have any impact on the build system, especially that this > part is used for variable history and logging. > > Would you want to make this change specific only to toaster ? > > From: Damian, Alexandru [mailto:alexandru.damian@intel.com > ] > Sent: Tuesday, March 18, 2014 4:45 PM > To: Avram, Marius > Cc: toaster@yoctoproject.org > Subject: Re: [Toaster] [PATCH] toaster: full path in variable history > > This patch is not in a toaster-only file, I think it affects other > parts of Bitbake code. > > Can you please elaborate on the test plan you used to validate > this change ? > > Thank you, > Alex > > On Tue, Mar 18, 2014 at 12:32 PM, Marius Avram > >> wrote: > When an evaluation was made for a configuration file the path to the > file was saved as a relative one. The change in this commit will > save the > location as an absolute path. This way the user will have full > information > regarding the location of the file where a variable was changed > and the > line withing the file. > > [YOCTO #5562] > > Signed-off-by: Marius Avram >> > --- > bitbake/lib/bb/parse/parse_py/ConfHandler.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bitbake/lib/bb/parse/parse_py/ConfHandler.py > b/bitbake/lib/bb/parse/parse_py/ConfHandler.py > index f4fb2aa..978ebe4 100644 > --- a/bitbake/lib/bb/parse/parse_py/ConfHandler.py > +++ b/bitbake/lib/bb/parse/parse_py/ConfHandler.py > @@ -144,7 +144,7 @@ def handle(fn, data, include): > # skip comments > if s[0] == '#': > continue > - feeder(lineno, s, fn, statements) > + feeder(lineno, s, abs_fn, statements) > > # DONE WITH PARSING... time to evaluate > data.setVar('FILE', abs_fn) > -- > 1.7.9.5 > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > > > https://lists.yoctoproject.org/listinfo/toaster > > > > -- > Alex Damian > Yocto Project > SSG / OTC > > > > > -- > Alex Damian > Yocto Project > SSG / OTC --------------020401050205060905080701 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit I've made a build for core-image-minimal on top of commit master:3c70ad664685716d8d805aebf211daff4a062d1a with my patch applied  inside a new build directory and I can confirm that the building process finished successfully.

On 03/18/2014 05:40 PM, Damian, Alexandru wrote:
Please validate that the reading of the config files is not affected by deleting the recipe cache and trying to build from scratch.
This change cascades into the ast parser, not just logging and variable history.

Alex


On Tue, Mar 18, 2014 at 3:15 PM, Avram, Marius <marius.avram@intel.com> wrote:
I only tested if the file_name fields from VariableHistory model is filled correctly by accessing:
http://localhost:8000/api/1.0/variablehistory  which returns a JSON of the table.

I thought that replacing a relative path with an absolute path will not have any impact on the build system, especially that this part is used for variable history and logging.

Would you want to make this change specific only to toaster ?

From: Damian, Alexandru [mailto:alexandru.damian@intel.com]
Sent: Tuesday, March 18, 2014 4:45 PM
To: Avram, Marius
Cc: toaster@yoctoproject.org
Subject: Re: [Toaster] [PATCH] toaster: full path in variable history

This patch is not in a toaster-only file, I think it affects other parts of Bitbake code.

Can you please elaborate on the test plan you used to validate this change ?

Thank you,
Alex

On Tue, Mar 18, 2014 at 12:32 PM, Marius Avram <marius.avram@intel.com<mailto:marius.avram@intel.com>> wrote:
When an evaluation was made for a configuration file the path to the
file was saved as a relative one. The change in this commit will save the
location as an absolute path. This way the user will have full information
regarding the location of the file where a variable was changed and the
line withing the file.

[YOCTO #5562]

Signed-off-by: Marius Avram <marius.avram@intel.com<mailto:marius.avram@intel.com>>
---
 bitbake/lib/bb/parse/parse_py/ConfHandler.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bitbake/lib/bb/parse/parse_py/ConfHandler.py b/bitbake/lib/bb/parse/parse_py/ConfHandler.py
index f4fb2aa..978ebe4 100644
--- a/bitbake/lib/bb/parse/parse_py/ConfHandler.py
+++ b/bitbake/lib/bb/parse/parse_py/ConfHandler.py
@@ -144,7 +144,7 @@ def handle(fn, data, include):
         # skip comments
         if s[0] == '#':
             continue
-        feeder(lineno, s, fn, statements)
+        feeder(lineno, s, abs_fn, statements)

     # DONE WITH PARSING... time to evaluate
     data.setVar('FILE', abs_fn)
--
1.7.9.5

--
_______________________________________________
toaster mailing list
toaster@yoctoproject.org<mailto:toaster@yoctoproject.org>
https://lists.yoctoproject.org/listinfo/toaster



--
Alex Damian
Yocto Project
SSG / OTC



--
Alex Damian
Yocto Project
SSG / OTC 

--------------020401050205060905080701--